Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10711 Add Scope to WirelessLAN #17877

Merged
merged 50 commits into from
Nov 7, 2024
Merged

10711 Add Scope to WirelessLAN #17877

merged 50 commits into from
Nov 7, 2024

Conversation

arthanson
Copy link
Collaborator

Fixes: #10711

@arthanson
7699 Add Scope to Cluster
2bb49d7
@arthanson
7699 Serializer
dcb3c7c
@arthanson
7699 filterset
33b4beb
@arthanson
7699 bulk_edit
286f56b
@arthanson
7699 bulk_import
4c3d1ce
@arthanson
7699 model_form
d19cef4
@arthanson
7699 graphql, tables
7e6bb0e
@arthanson
7699 fixes
8a63707
@arthanson
7699 fixes
be59775
@arthanson
7699 fixes
76e438d
@arthanson
7699 fixes
ee99056
@arthanson
7699 fix tests
071b960
@arthanson
7699 fix graphql tests for clusters reference
4112af5
@arthanson
7699 fix dcim tests
65295f6
@arthanson
7699 fix ipam tests
9108915
@arthanson
7699 fix tests
c73902c
@arthanson
7699 use mixin for model
cfdab0e
@arthanson
7699 change mixin name
3525a3a
@arthanson
7699 scope form
d7b204a
@arthanson
7699 scope form
8ca7cdd
@arthanson
7699 scoped form, fitlerset
277b175
@arthanson
7699 review changes
62358f6
@arthanson
7699 move ScopedFilterset
c75bfe1
@arthanson
7699 move CachedScopeMixin
c500545
@arthanson
7699 review changes
effe920
@arthanson
10711 Add Scope to WirelessLAN
4d01069
@arthanson
10711 Add Scope to WirelessLAN
06c8a92
@arthanson
10711 Add Scope to WirelessLAN
d41cc97
@arthanson
10711 Add Scope to WirelessLAN
c91c9e5
@arthanson
10711 Add Scope to WirelessLAN
8bafef6
@jeremystretch jeremystretch added this to the v4.2 milestone Oct 29, 2024
@arthanson arthanson changed the title DRAFT: 10711 Add Scope to WirelessLAN 10711 Add Scope to WirelessLAN Nov 4, 2024
@arthanson arthanson marked this pull request as ready for review November 4, 2024 19:09
jeremystretch
jeremystretch requested changes Nov 5, 2024
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wireless LAN HTML template needs to be extended to show the assigned scope.

This also needs API tests.

netbox/dcim/forms/mixins.py Outdated Show resolved Hide resolved
netbox/wireless/api/serializers_/wirelesslans.py Show resolved Hide resolved
netbox/wireless/forms/bulk_import.py Outdated Show resolved Hide resolved
netbox/wireless/forms/model_forms.py Outdated Show resolved Hide resolved
netbox/wireless/graphql/types.py Show resolved Hide resolved
netbox/wireless/tests/test_filtersets.py Show resolved Hide resolved
netbox/wireless/tests/test_views.py Outdated Show resolved Hide resolved
jeremystretch
jeremystretch approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've extended the CSV test data.

@jeremystretch jeremystretch merged commit 812ce84 into feature Nov 7, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 10711-wirelesslan-scope branch November 7, 2024 15:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bctiemann bctiemann bctiemann approved these changes

@jeremystretch jeremystretch jeremystretch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@arthanson @bctiemann @jeremystretch