Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace None with 'null' in query parameters #545

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

doc-sheet
Copy link

Requests skips parameters that are None.
Map 'null' string to None python type for a more native coding

eg: nb.dcim.interfaces.filter(mac_address__n=None)

Copy link
Member

@abhi1693 abhi1693 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide a test case for this?

doc-sheet pushed a commit to doc-sheet/pynetbox that referenced this pull request Aug 25, 2023
@doc-sheet
Copy link
Author

Sure. Done.

@doc-sheet doc-sheet changed the title replace None with 'null' in query paramters replace None with 'null' in query parameters Aug 28, 2023
@abhi1693
Copy link
Member

@doc-sheet Looks like the linter is failing. Please update this and let me know once its ready to review.

@doc-sheet
Copy link
Author

doc-sheet commented Aug 28, 2023

@abhi1693 I removed line breaks.
And monkeypatch as well.

Requests skips parameters that are None.
Map 'null' string to None python type for a more native coding
@arthanson arthanson changed the base branch from master to develop August 8, 2024 06:41
@arthanson arthanson merged commit 314e006 into netbox-community:develop Aug 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants