Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.12 in tests and other lists #601

Closed

Conversation

markkuleinio
Copy link
Contributor

Fixes: #600

Added Python 3.12 in tests, setup.py classifiers and in the bug report forms.

@markkuleinio
Copy link
Contributor Author

markkuleinio commented Jan 4, 2024

I did not change .readthedocs.yaml yet, I guess that's just for building the docs, maybe that can be done later.

@markkuleinio
Copy link
Contributor Author

I don't know how to fix the failing tests, @abhi1693

Container pytest_pynetbox_1704357384-netbox_v3_3_netbox-housekeeping-1 Created
Error response from daemon: failed to mkdir /var/lib/docker/volumes/pytest_pynetbox_1704357384_pytest_pynetbox_v3_3_netbox-media-files/_data/image-attachments: mkdir /var/lib/docker/volumes/pytest_pynetbox_1704357384_pytest_pynetbox_v3_3_netbox-media-files/_data/image-attachments: file exists

@abhi1693
Copy link
Member

abhi1693 commented Jan 4, 2024

It's possible that 3.12 was not supported with older netbox versions.

@markkuleinio
Copy link
Contributor Author

It's possible that 3.12 was not supported with older netbox versions.

Why would that be shown as a docker volume creation error? (Sorry, I'm not a dockerist)

@markkuleinio
Copy link
Contributor Author

markkuleinio commented Jan 4, 2024

I'll still try with NetBox 3.7 only, just a minute

(update: it worked)

@markkuleinio
Copy link
Contributor Author

markkuleinio commented Jan 4, 2024

Added NetBox 3.3. I don't see the logic: now it failed the Python 3.8 + NetBox 3.3 test. Something is wrong in the docker logic, cannot help that. Restoring the original changes now

@markkuleinio
Copy link
Contributor Author

markkuleinio commented Jan 4, 2024

Looks like the docker image for NetBox 3.3 is not working, others are fine, including tests with Python 3.12.

.github/ISSUE_TEMPLATE/bug_report.yaml Outdated Show resolved Hide resolved
@arthanson arthanson closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add classifier and testing for Python 3.12
3 participants