Add TCP metrics

[thiagoftsm]

This PR is bringing the following metrics to WMI:

[ilyam8]

Hi. Thanks! You added windows_service_info testdata lines in this PR (TCP). By accident, I guess. Pls, remove them.

[thiagoftsm]

Hi. Thanks! You added windows_service_info testdata lines in this PR (TCP). By accident, I guess. Pls, remove them.

You are right, I already removed them.

[ilyam8]

@thiagoftsm, no, you didn't. I meant to say windows_service_*, not info only. I believe this should make sense for you because of the PR title (TCP).

[thiagoftsm]

@thiagoftsm, no, you didn't. I meant to say windows_service_*, not info only. I believe this should make sense for you because of the PR title (TCP).

You did not request to remvoe windows_service_* you asked for windows_service_info. 😄
Last commit removed the remaining metrics.

[milindpatel63]

do we need to update the wmi collector command on our windows machine to collect these new "TCP" metrics?

Previous command was,

msiexec -i <path-to-msi-file> ENABLED_COLLECTORS=cpu,memory,net,logical_disk,os,system,logon,thermalzone

Should we just add "tcp" to enabled collectors?

[thiagoftsm]

Hello @milindpatel63 ,

You will need to add ,tcp for the given command:

msiexec -i <path-to-msi-file> ENABLED_COLLECTORS=cpu,memory,net,logical_disk,os,system,logon,thermalzone,tcp

After this windows exporter will expose metrics and go.d.plugin will be able to collect.

Best regards!

[milindpatel63]

Hello @milindpatel63 ,

You will need to add ,tcp for the given command:

msiexec -i <path-to-msi-file> ENABLED_COLLECTORS=cpu,memory,net,logical_disk,os,system,logon,thermalzone,tcp

After this windows exporter will expose metrics and go.d.plugin will be able to collect.

Best regards!

Got it.
Kindly also update this info in the official docs here: https://learn.netdata.cloud/docs/agent/collectors/go.d.plugin/modules/wmi#requirements after the changes are merged in netdata master branch.

[thiagoftsm]

Hello @milindpatel63 ,

You are right, I already push a commit updating the PR netdata/netdata#13878, and I made a new PR on this repo (#943) to update local documentation.

Thank you !