Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When listening on a unix socket, web server still attempts to set TCP_NODELAY. #3682

Closed
declaresub opened this issue May 3, 2018 · 2 comments · Fixed by #3691
Closed

When listening on a unix socket, web server still attempts to set TCP_NODELAY. #3682

declaresub opened this issue May 3, 2018 · 2 comments · Fixed by #3691
Labels

Comments

@declaresub
Copy link

When listening on a unix socket, web server still attempts to set TCP_NODELAY, resulting in error 95. The problem is that the log fills up with error messages until a message threshold is triggered.

@Ferroin
Copy link
Member

Ferroin commented May 4, 2018

I can confirm this, and agree that it's rather irritating. I'm personally of the opinion that the message probably shouldn't be an error message, but a debug message (things do still work if we fail to set this flag, it's just that there will be some more latency in the dashboard), though that would just move the log spam instead of getting rid of it.

For whoever ends up looking into this, the issue is that web_client_initialize_connection() in web_server.c is unconditionally trying to set TCP_NODELAY, without checking the socket type first. I would try to fix this myself, but I'm not all that comfortable poking around there given that I don't have much experience with C (I know enough to read it, just not enough to confidently write it).

@ktsaou
Copy link
Member

ktsaou commented May 7, 2018

In PR #3691
Thank you for reporting it!

@ktsaou ktsaou added the fixed label May 7, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants