remove mqtt-c from websockets #14181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/aclk
area/build
underhood
force-pushed
the
remove_mqtt_c
branch
from
ab6fb17
to
e38cd92
Compare
underhood
requested review from
netdatabot,
DShreve2,
tkatsoulas,
thiagoftsm,
MrZammler,
vkalintiris and
stelfrag
as code owners
github-actions
bot
added
area/ci
area/collectors
|
Hello @underhood , Please, rebase your PR to remove conflicts. Best regards! |
|
@thiagoftsm not ready for review in summary i write: we have to merge those 2 first before we can go ahead with this one |
underhood
force-pushed
the
remove_mqtt_c
branch
from
e38cd92
to
a23655b
Compare
github-actions
bot
removed
collectors/apps
area/packaging
github-actions
bot
removed
area/collectors
underhood
changed the title
|
@thiagoftsm rebased. Most important in the review here is to check underhood/mqtt_websockets#15 (which this PR will bring in) doesn't accidentally change behavior from now when mqtt5 is true |
thiagoftsm
previously approved these changes
Jan 17, 2023
|
submodule points to master |
underhood
requested review from
thiagoftsm
and removed request for
DShreve2,
Ferroin,
netdatabot and
tkatsoulas
vkalintiris
approved these changes
Jan 23, 2023
stelfrag
approved these changes
Jan 23, 2023
thiagoftsm
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes support for MQTT-C library and keeps only new MQTT5 implementation.
This cleans up the code and is prerequisite for next improvements and fixes which are coming.
Test Plan
Behavior should be same as before this PR with mqtt5 switched on
Additional Information
For users: How does this change affect me?