Add nvidia smi pci bandwidth percent collector #14315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
area/collectors
ghanapunq
force-pushed
the
nvidia-smi-pci-bandwidth-percent-collector
branch
from
28498ee
to
8866d46
Compare
ilyam8
reviewed
Jan 25, 2023
ilyam8
reviewed
Jan 27, 2023
ilyam8
reviewed
Jan 30, 2023
|
@ghanapunq also check the Codacy warnings |
ilyam8
reviewed
Jan 30, 2023
Co-authored-by: Ilya Mashchenko <ilya@netdata.cloud>
ilyam8
reviewed
Jan 31, 2023
ilyam8
approved these changes
Feb 1, 2023
|
@ilyam8 thanks for the review. Would you know who else could review my pull request to unblock it ? |
Did you test the latest changes? If no - please do. |
thiagoftsm
approved these changes
Feb 1, 2023
|
i tested the changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change enables the calculation of the PCIE bandwidth in percent.
Test Plan
Tested manually on two different machines. One with a GPU Quadro RTX 4000 and the other one with GPU RTX A4500
Additional Information
To have a quick overview about the pcie bandwidth available, I though it was useful to have the values of TX/RX bandwidth in percent. To do so it calculates the maximum theoretical bandwidth thanks to the pcie generation and width given by nvidia-smi, thus the value in percent can be deduced.
For users: metric netdata_nvidia_smi_pci_bandwidth_KiB_persec_average enhanced
It changes the nvidia-smi plugin only. And two dimensions rx_percent and tx_percent have been added to the netdata_nvidia_smi_pci_bandwidth_KiB_persec_average metric.