Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dashboard #14342

Merged
merged 11 commits into from
Feb 2, 2023
Merged

Update dashboard #14342

merged 11 commits into from
Feb 2, 2023

Conversation

thiagoftsm
Copy link
Contributor

@thiagoftsm thiagoftsm commented Jan 29, 2023

Summary

This PR is bringing updates for our dashboard showing better name for WMI module.
Screenshot_20230201_212743

Test Plan
  1. Copy the dashboard_info.js to final destination and load it on host that has WMI module running.
Additional Information

We are not briging additional information for majority of charts, because title is already explains the chart.

For users: How does this change affect me? Describe the PR affects users: - Which area of Netdata is affected by the change? dashboard - Can they see the change or is it an under the hood? If they can see it, where? Only when they are running WMI module. - How is the user impacted by the change? A better description/visualization for chart,. - What are there any benefits of the change? A more clear dashboard.

web/gui/dashboard_info.js Outdated Show resolved Hide resolved
@thiagoftsm thiagoftsm marked this pull request as ready for review January 31, 2023 12:16
@thiagoftsm thiagoftsm marked this pull request as draft February 1, 2023 13:01
@thiagoftsm thiagoftsm marked this pull request as ready for review February 1, 2023 21:28
web/gui/dashboard_info.js Outdated Show resolved Hide resolved
web/gui/dashboard_info.js Outdated Show resolved Hide resolved
shyamvalsan
shyamvalsan previously approved these changes Feb 2, 2023
ilyam8
ilyam8 previously approved these changes Feb 2, 2023
web/gui/dashboard_info.js Outdated Show resolved Hide resolved
@thiagoftsm thiagoftsm dismissed stale reviews from ilyam8 and shyamvalsan via 9d103ae February 2, 2023 14:33
@ilyam8 ilyam8 removed the request for review from jacekkolasa February 2, 2023 14:37
@thiagoftsm thiagoftsm merged commit 1bf5c70 into netdata:master Feb 2, 2023
@thiagoftsm thiagoftsm deleted the update_dashboard branch February 2, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants