Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/api/v2/X part 5 #14718

Merged
merged 31 commits into from
Mar 21, 2023
Merged

/api/v2/X part 5 #14718

merged 31 commits into from
Mar 21, 2023

Conversation

ktsaou
Copy link
Member

@ktsaou ktsaou commented Mar 14, 2023 •
edited
Loading

  • query timestamps are now pre-determined and alignment on timestamps is guaranteed. This is a bug fix of an issue introduced to the query engine when merging tiers was improved. There was a possibility of different metrics to skip a point at different timestamps, corrupting the timestamps of the entire query. Now the timestamps are predetermined and fixed and they never change during a dimension query.
  • enable /api/v2/X queries via ACLK.
  • /api/v2/nodes is now enriched with all the information cloud provides.
  • added nodes_hard_hash, alerts_hard_hash and alerts_soft_hash to allow the UI when it needs to update nodes and alerts
  • added collection and streaming status, including replication to nodes endpoint
  • /api/v2/weights working with the same filtering parameters as /api/v2/data (multi-node, filtering based on nodes, contexts, instances, dimensions, labels, alerts)
  • /api/v2/weights now does a normal query when scope_contexts or contexts are defined.

stelfrag
stelfrag previously approved these changes Mar 14, 2023
View reviewed changes
@ktsaou ktsaou requested a review from MrZammler as a code owner March 15, 2023 23:55
@ktsaou
expose min and max in sts structures
ac483a4
@ktsaou
added view_minimum_value and view_maximum_value; percentage calculati…
53f348d 
…on is now an additional pass on the data, removed from formatters; absolute value calculation is now done at the query level, removed from formatters
@ktsaou
respect trimming in percentage calculation; updated swagger
cb61334
@ktsaou
api/v2/weights preparative work to support multi-node queries - still…
b25ee0d 
… single node though
@ktsaou
multi-node /api/v2/weights endpoint, supporting all the filtering par…
33942f2 
…ameters of /api/v2/data
@ktsaou
when passing the raw option, the query exposes the hidden dimensions
5335b77
@ktsaou
fix compilation issues on older systems
7af133b
@ktsaou
the query engine now calculates per dimension min, max, sum, count, a…
3233479 
…nomaly count
@ktsaou
use the macro to calculate storage point anomaly rate
7f4a979
@ktsaou ktsaou requested a review from Ferroin as a code owner March 19, 2023 23:10
@github-actions github-actions bot added the area/build Build system (autotools and cmake). label Mar 19, 2023
@github-actions github-actions bot removed the area/build Build system (autotools and cmake). label Mar 20, 2023
@ktsaou ktsaou merged commit 5eed054 into netdata:master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stelfrag stelfrag stelfrag approved these changes

@thiagoftsm thiagoftsm Awaiting requested review from thiagoftsm

@vkalintiris vkalintiris Awaiting requested review from vkalintiris

@underhood underhood Awaiting requested review from underhood

@MrZammler MrZammler Awaiting requested review from MrZammler

@Ferroin Ferroin Awaiting requested review from Ferroin Ferroin is a code owner

Assignees
No one assigned
Labels
area/aclk area/database area/health area/streaming area/web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktsaou @stelfrag