Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force symlink of netdata-updater.sh #4307

Merged
merged 1 commit into from
Sep 27, 2018
Merged

force symlink of netdata-updater.sh #4307

merged 1 commit into from
Sep 27, 2018

Conversation

mrdrogdrog
Copy link
Contributor

@mrdrogdrog mrdrogdrog commented Sep 27, 2018

Today I moved the netdata git into another directory and executed the installer to refresh the files with the new path. But the script failed when it tried to (re)create the symlink for the cronjob. This fix just adds the force flag to ln.

@CLAassistant
Copy link

CLAassistant commented Sep 27, 2018

CLA assistant check
All committers have signed the CLA.

@paulfantom paulfantom merged commit 5ad6478 into netdata:master Sep 27, 2018
@ktsaou
Copy link
Member

ktsaou commented Sep 27, 2018

btw, @paulfantom for all these fixes I always check if the command will work on busybox. We need it to work on docker (alpine) and embedded devices, so busybox is important.

busybox has -f for ln. So this was ok.

@paulfantom
Copy link
Contributor

From our .travis.yml:

netdata/.travis.yml

Lines 62 to 64 in 5ad6478

# TODO: cannot run installer without bash
# - name: "alpine"
# script: ./.travis/containerized_build.sh alpine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants