Updated Polyverse reinstall commands in Dockerfile #5173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem: After this PR was merged (#5137), we noticed on our end that the default Polyverse install script had room for improvement to ensure there's reliability. To be more specific, we noticed that while we only expose x86_64 packages, we noticed a pull to an x86 (32-bit package) that was not expected. What this meant was, during our first update, we were completely removing existing mirrors/packages in the install script. The fix: Our install script now merely comments out the existing repos/mirrors. The install instructions then merely update/upgrade all packages in-place, this preferring our packages as a priority, and the final command uncomments all the other mirrors/repos that may exist. The outcome: Due to this step, ALL existing repos stay on the host after Polymorphic repositories are sbuscribed. Everything works as expected. However, the host will prefer Polymorphic repositories above others.
|
|
kiku-jw
pushed a commit
to kiku-jw/netdata
that referenced
this pull request
Mar 4, 2019
The problem: After this PR was merged (netdata#5137), we noticed on our end that the default Polyverse install script had room for improvement to ensure there's reliability. To be more specific, we noticed that while we only expose x86_64 packages, we noticed a pull to an x86 (32-bit package) that was not expected. What this meant was, during our first update, we were completely removing existing mirrors/packages in the install script. The fix: Our install script now merely comments out the existing repos/mirrors. The install instructions then merely update/upgrade all packages in-place, this preferring our packages as a priority, and the final command uncomments all the other mirrors/repos that may exist. The outcome: Due to this step, ALL existing repos stay on the host after Polymorphic repositories are sbuscribed. Everything works as expected. However, the host will prefer Polymorphic repositories above others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem:
After this PR was merged (#5137),
we noticed on our end that the default Polyverse install script
had room for improvement to ensure there's reliability.
To be more specific, we noticed that while we only expose x86_64 packages,
we noticed a pull to an x86 (32-bit package) that was not expected.
What this meant was, during our first update, we were completely removing
existing mirrors/packages in the install script.
The fix:
Our install script now merely comments out the existing repos/mirrors.
The install instructions then merely update/upgrade all packages in-place,
this preferring our packages as a priority, and the final command
uncomments all the other mirrors/repos that may exist.
The outcome:
Due to this step, ALL existing repos stay on the host after Polymorphic
repositories are sbuscribed. Everything works as expected. However,
the host will prefer Polymorphic repositories above others.
Summary
Component Name
Additional Information