Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement unified cgroup cpu limit #5895

Merged
merged 12 commits into from
May 10, 2019
Merged

Implement unified cgroup cpu limit #5895

merged 12 commits into from
May 10, 2019

Conversation

skrzyp1
Copy link
Contributor

@skrzyp1 skrzyp1 commented Apr 18, 2019 •
edited by vlvkobal
Loading

Summary

Closes #5850

Component Name

cgroups.plugin

@skrzyp1 skrzyp1 mentioned this pull request Apr 18, 2019
Closed
@netdatabot netdatabot added the area/collectors Everything related to data collection label Apr 20, 2019
vlvkobal
vlvkobal suggested changes May 7, 2019
View reviewed changes
Copy link
Contributor

@vlvkobal vlvkobal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix this warning:

collectors/cgroups.plugin/sys_fs_cgroup.c: In function 'update_cpu_limits2':
collectors/cgroups.plugin/sys_fs_cgroup.c:2618:13: warning: unused variable 'ret' [-Wunused-variable]
         int ret = -1;

vlvkobal
vlvkobal suggested changes May 7, 2019
View reviewed changes
collectors/cgroups.plugin/sys_fs_cgroup.c Outdated Show resolved Hide resolved
collectors/cgroups.plugin/sys_fs_cgroup.c Outdated Show resolved Hide resolved
collectors/cgroups.plugin/sys_fs_cgroup.c Outdated Show resolved Hide resolved
collectors/cgroups.plugin/sys_fs_cgroup.c Outdated Show resolved Hide resolved
@vlvkobal
Copy link
Contributor

vlvkobal commented May 7, 2019

Everything else looks good to me.

@skrzyp1 skrzyp1 changed the title Wip Implement unified cgroup cpu limit Implement unified cgroup cpu limit May 9, 2019
@vlvkobal vlvkobal merged commit c82f4a1 into netdata:master May 10, 2019
jackyhuang85 pushed a commit to jackyhuang85/netdata that referenced this pull request Jan 1, 2020
@skrzyp1 @jackyhuang85
Implement unified cgroup cpu limit (netdata#5895)
f2557b3 
* WiP unified cgroup support

* add cpu usage support and disk iops support

* memory limits

* WIP working memory charts

* detailed memory chart

* docs change

* cpu limit function

* review changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlvkobal vlvkobal vlvkobal approved these changes

@cakrit cakrit Awaiting requested review from cakrit

@ktsaou ktsaou Awaiting requested review from ktsaou

Assignees
No one assigned
Labels
area/collectors Everything related to data collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement CPU limits for cgroup v2
3 participants
@skrzyp1 @vlvkobal @netdatabot