Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lint action to calculate diff on master #283

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

GabriFila
Copy link
Contributor

Description

This PR includes a little change to the linting action. We updated the version of the action to calculate the diff, now it calculates the diff with the base (master) branch, as discusses here

How Has This Been Tested?

This commit is the first in the new remote branch and it doesn't fail and doesn't run the linting since nothing has changed in the /webservice folder

Copy link
Member

@palexster palexster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@giorio94 giorio94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@GabriFila GabriFila force-pushed the gbf/update_lint_action branch from d330871 to 42c922f Compare July 14, 2020 12:33
@GabriFila GabriFila merged commit bc77c7b into master Jul 14, 2020
@GabriFila GabriFila deleted the gbf/update_lint_action branch July 14, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants