Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize Instance status phase #755

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

QcFe
Copy link
Collaborator

@QcFe QcFe commented Feb 16, 2022

Description

This PR removes the old VMI text from Instance status.

@QcFe QcFe requested a review from a team as a code owner February 16, 2022 13:30
@kingmakerbot
Copy link
Collaborator

Hi @QcFe. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@kingmakerbot
Copy link
Collaborator

The generated files in the operators/ folder appear to be out-of-date.

Please, ensure you are using the correct version of controller-gen and re-run:

make generate
make manifests
Here it is an excerpt of the diff:
diff --git a/operators/deploy/crds/crownlabs.polito.it_instances.yaml b/operators/deploy/crds/crownlabs.polito.it_instances.yaml
index 33bddd7..7e299f3 100644
--- a/operators/deploy/crds/crownlabs.polito.it_instances.yaml
+++ b/operators/deploy/crds/crownlabs.polito.it_instances.yaml
@@ -181,7 +181,7 @@ spec:
               - Running
               - Ready
               - Stopping
-                - Off
+                - "Off"
               - Failed
               - CreationLoopBackoff
               type: string

@QcFe QcFe force-pushed the qcfe/instance-status-normalization branch from ac8b6cd to 2d5670d Compare February 16, 2022 14:37
operators/api/v1alpha2/instance_types.go Outdated Show resolved Hide resolved
@QcFe QcFe force-pushed the qcfe/instance-status-normalization branch from 2d5670d to a682ad5 Compare February 16, 2022 16:56
@giorio94
Copy link
Member

/merge

@kingmakerbot kingmakerbot merged commit 0c4c28c into master Feb 16, 2022
@kingmakerbot kingmakerbot deleted the qcfe/instance-status-normalization branch February 16, 2022 17:58
@giorio94 giorio94 added the kind/cleanup Refactoring code label Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants