Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sandbox environment: add limit range creation #770

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Sandbox environment: add limit range creation #770

merged 2 commits into from
Mar 30, 2022

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Mar 26, 2022 •
edited
Loading

Description

This PR enhances the management of the sandbox environment, introducing the creation of a limit range object. It sets default request/limit values, preventing the need for explicit configuration in each deployment.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Automated tests
  • Staging environment

@giorio94 giorio94 added the kind/feature New feature or request label Mar 26, 2022
@kingmakerbot
Copy link
Collaborator

Hi @giorio94. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@giorio94
Copy link
Member Author

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Storybook, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-770 label to your tenant.

@giorio94
Copy link
Member Author

/deploy-staging

@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly deployed/updated!
Available here: Frontend, Storybook, Qlkube
Operators: add the crownlabs.polito.it/operator-selector=staging-770 label to your tenant.

@giorio94 giorio94 requested a review from QcFe March 26, 2022 11:48
@giorio94 giorio94 marked this pull request as ready for review March 26, 2022 11:49
@giorio94 giorio94 requested a review from a team as a code owner March 26, 2022 11:49
@giorio94
Copy link
Member Author

/rebase

@giorio94
Copy link
Member Author

/merge

@kingmakerbot kingmakerbot merged commit 81ffd5f into master Mar 30, 2022
@kingmakerbot kingmakerbot deleted the mio/sandbox-limit-range branch March 30, 2022 13:27
@kingmakerbot
Copy link
Collaborator

Your staging environment has been correctly teared-down!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QcFe QcFe QcFe approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request sig/api sig/operations size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giorio94 @kingmakerbot @QcFe