Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golangci-lint version and fix issues #823

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

giorio94
Copy link
Member

Description

This PR bumps golangci-lint to the latest version, removes deprecated linters, and fixes the reported issues.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Existing tests
  • Ensuring no lining errors are reported.

@giorio94 giorio94 added the kind/cleanup Refactoring code label Dec 12, 2022
@giorio94 giorio94 requested a review from QcFe December 12, 2022 18:04
@giorio94 giorio94 requested a review from a team as a code owner December 12, 2022 18:04
@kingmakerbot
Copy link
Collaborator

Hi @giorio94. Thanks for your PR.

I am @kingmakerbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /hold: Adds hold label to prevent merging with /merge
  • /unhold: Removes the hold label to allow merging with /merge
  • /deploy-staging: Deploy a staging environment to test this PR (the build-all flag enables user environments building)
  • /undeploy-staging: Manually undeploy the staging environment

Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

Copy link
Collaborator

@QcFe QcFe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@giorio94
Copy link
Member Author

/rebase

@giorio94
Copy link
Member Author

/merge

@kingmakerbot kingmakerbot merged commit e413b96 into netgroup-polito:master Dec 14, 2022
@giorio94 giorio94 deleted the mio/golangci-lint branch January 6, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants