refactor(v2): return avatar url when finish

src/v2/controllers/user/upload-avatar/finish.ts

@@ -1,6 +1,7 @@
 import { Type } from "@sinclair/typebox";
 import { FastifyRequestTypebox, Response } from "../../../../types/Server";
 import { UserUploadAvatarService } from "../../../services/user/upload-avatar";
+import { UserUploadAvatarFinishReturn } from "../../../services/user/upload-avatar.type";
 import { successJSON } from "../../internal/utils/response-json";
 
 export const userUploadAvatarFinishSchema = {
@@ -13,14 +14,14 @@ export const userUploadAvatarFinishSchema = {
 
 export const userUploadAvatarFinish = async (
     req: FastifyRequestTypebox<typeof userUploadAvatarFinishSchema>,
-): Promise<Response> => {
+): Promise<Response<UserUploadAvatarFinishReturn>> => {
     const userUploadAvatarSVC = new UserUploadAvatarService(
         req.ids,
         req.DBTransaction,
         req.userUUID,
     );
 
-    await userUploadAvatarSVC.finish(req.body.fileUUID);
+    const result = await userUploadAvatarSVC.finish(req.body.fileUUID);
 
-    return successJSON({});
+    return successJSON(result);
 };

src/v2/services/user/upload-avatar.ts

@@ -2,6 +2,7 @@ import { createLoggerService, parseError } from "../../../logger";
 import { EntityManager } from "typeorm";
 import {
     GetAvatarInfoByRedisReturn,
+    UserUploadAvatarFinishReturn,
     UserUploadAvatarStartConfig,
     UserUploadAvatarStartReturn,
 } from "./upload-avatar.type";
@@ -62,7 +63,7 @@ export class UserUploadAvatarService {
         };
     }
 
-    public async finish(fileUUID: string): Promise<void> {
+    public async finish(fileUUID: string): Promise<UserUploadAvatarFinishReturn> {
         const { fileName } = await this.getFileInfoByRedis(fileUUID);
 
         const ossFilePath = CloudStorageUploadService.generateOSSFilePath(fileName, fileUUID);
@@ -75,7 +76,8 @@ export class UserUploadAvatarService {
         const { avatarURL: oldAvatarURL } = await userInfoSVC.basicInfo();
 
         const userUpdateSVC = new UserUpdateService(this.ids, this.DBTransaction, this.userUUID);
-        await userUpdateSVC.avatarURL(`${this.oss.domain}/${ossFilePath}`);
+        const newAvatarURL = `${this.oss.domain}/${ossFilePath}`;
+        await userUpdateSVC.avatarURL(newAvatarURL);
 
         if (oldAvatarURL.startsWith(this.oss.domain)) {
             this.oss.remove(oldAvatarURL).catch(error => {
@@ -100,6 +102,8 @@ export class UserUploadAvatarService {
                 });
             },
         );
+
+        return { avatarURL: newAvatarURL };
     }
 
     public async getFileInfoByRedis(fileUUID: string): Promise<GetAvatarInfoByRedisReturn> {

src/v2/services/user/upload-avatar.type.ts

@@ -14,3 +14,7 @@ export interface UserUploadAvatarStartReturn {
 export interface GetAvatarInfoByRedisReturn {
     fileName: string;
 }
+
+export interface UserUploadAvatarFinishReturn {
+    avatarURL: string;
+}