fix(service-providers): electron role publishing wrong (#1763)

- switch back to vp8 in web mode for compatibility with electron
netless-io · Nov 8, 2022 · 7d4325d · 7d4325d
1 parent 67615b0
commit 7d4325d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/service-providers/agora-rtc/agora-rtc-electron/src/rtc-local-avatar.ts b/service-providers/agora-rtc/agora-rtc-electron/src/rtc-local-avatar.ts
@@ -67,7 +67,9 @@ export class RTCLocalAvatar implements IServiceVideoChatAvatar {
                             this._rtc.rtcEngine.enableLocalAudio(true);
                         } else {
                             this._rtc.rtcEngine.enableLocalAudio(false);
-                            this._rtc.setRole(IServiceVideoChatRole.Audience);
+                            if (!this._shouldCamera$.value) {
+                                this._rtc.setRole(IServiceVideoChatRole.Audience);
+                            }
                         }
                     } catch (e) {
                         console.error(e);
@@ -85,7 +87,9 @@ export class RTCLocalAvatar implements IServiceVideoChatAvatar {
                             this._rtc.rtcEngine.enableLocalVideo(true);
                         } else {
                             this._rtc.rtcEngine.enableLocalVideo(false);
-                            this._rtc.setRole(IServiceVideoChatRole.Audience);
+                            if (!this._shouldMic$.value) {
+                                this._rtc.setRole(IServiceVideoChatRole.Audience);
+                            }
                         }
                     } catch (e) {
                         console.error(e);

diff --git a/service-providers/agora-rtc/agora-rtc-web/src/agora-rtc-web.ts b/service-providers/agora-rtc/agora-rtc-web/src/agora-rtc-web.ts
@@ -289,7 +289,7 @@ export class AgoraRTCWeb extends IServiceVideoChat {
 
         const client = AgoraRTC.createClient({
             mode: mode === IServiceVideoChatMode.Broadcast ? "live" : "rtc",
-            codec: "h264",
+            codec: "vp8",
         });
         this.client = client;
         this.mode = mode;

diff --git a/service-providers/agora-rtc/agora-rtc-web/src/rtc-share-screen.ts b/service-providers/agora-rtc/agora-rtc-web/src/rtc-share-screen.ts
@@ -29,7 +29,7 @@ export class AgoraRTCWebShareScreen extends IServiceShareScreen {
 
         this.APP_ID = config.APP_ID;
 
-        this.client = AgoraRTC.createClient({ mode: "rtc", codec: "h264" });
+        this.client = AgoraRTC.createClient({ mode: "rtc", codec: "vp8" });
 
         this._el$ = new Val(config.element ?? null);