Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): force wait rtc join #1036

Merged
merged 1 commit into from
Oct 26, 2021
Merged

fix(web): force wait rtc join #1036

merged 1 commit into from
Oct 26, 2021

Conversation

hyrious
Copy link
Member

@hyrious hyrious commented Oct 26, 2021

No description provided.

BlackHole1
BlackHole1 previously approved these changes Oct 26, 2021
View reviewed changes
Copy link
Collaborator

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Cheerego7
Cheerego7 previously approved these changes Oct 26, 2021
View reviewed changes
@BlackHole1
Copy link
Collaborator

should this PR be withdrawn?
#1035

@hyrious
Copy link
Member Author

hyrious commented Oct 26, 2021

should this PR be withdrawn? #1035

Anyway, removing a ! is a good refactoring. Keep it.

@hyrious hyrious dismissed stale reviews from Cheerego7 and BlackHole1 via 36bb482 October 26, 2021 09:21
@BlackHole1
Copy link
Collaborator

should this PR be withdrawn? #1035

Anyway, removing a ! is a good refactoring. Keep it.

ok

@BlackHole1 BlackHole1 merged commit b3ea971 into netless-io:main Oct 26, 2021
@hyrious hyrious deleted the fix-rtc branch October 27, 2021 07:11
BlackHole1 pushed a commit that referenced this pull request Oct 30, 2021
@hyrious @BlackHole1
fix(web): force wait rtc join (#1036)
8684e30
@hyrious hyrious mentioned this pull request Nov 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlackHole1 BlackHole1 BlackHole1 approved these changes

@Cheerego7 Cheerego7 Cheerego7 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hyrious @BlackHole1 @Cheerego7