Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling #22

Merged
merged 1 commit into from
May 11, 2020
Merged

Improve error handling #22

merged 1 commit into from
May 11, 2020

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented May 11, 2020

This adds a try/catch around pa11y so that errors thrown there get reported as user errors.

For example, pa11y can time out.

Pa11y timed out (30000ms) 
    /opt/build/repo/node_modules/p-timeout/index.js:27:54 Timeout.setTimeout [as _onTimeout]

@ehmicky ehmicky requested a review from swyxio May 11, 2020 15:55
@ehmicky ehmicky self-assigned this May 11, 2020
@swyxio swyxio merged commit 74aa06b into master May 11, 2020
@swyxio swyxio deleted the feat/error-handling branch May 11, 2020 17:54
@swyxio
Copy link
Contributor

swyxio commented May 11, 2020

v0.0.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swyxio swyxio Awaiting requested review from swyxio

Assignees

@ehmicky ehmicky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehmicky @swyxio