Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support named deploy-scoped stores #181

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

eduardoboucas
Copy link
Member

@eduardoboucas eduardoboucas requested a review from a team as a code owner July 1, 2024 12:37
@github-actions github-actions bot added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Jul 1, 2024
Copy link

netlify bot commented Jul 1, 2024

Deploy Preview for blobs-js ready!

Name Link
🔨 Latest commit b54810f
🔍 Latest deploy log https://app.netlify.com/sites/blobs-js/deploys/6682d3811f52150008597467
😎 Deploy Preview https://deploy-preview-181--blobs-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


env.NETLIFY_BLOBS_CONTEXT = Buffer.from(JSON.stringify(context)).toString('base64')

const deployStore = getDeployStore(mockStoreName)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these 2 test names switched?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What?! The idea that I would do such a silly mistake is ludicrous.

(Yes. Yes, they were. b54810f)

@eduardoboucas eduardoboucas merged commit 7b24ef8 into main Jul 1, 2024
9 checks passed
@eduardoboucas eduardoboucas deleted the feat/deploy-named-stores branch July 1, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants