Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve build logs related to plugin event handlers #3721

Merged
merged 2 commits into from
Oct 14, 2021
Merged

Conversation

ehmicky
Copy link
Contributor

@ehmicky ehmicky commented Oct 12, 2021

This improves the headers used for plugin event handlers in the build logs:

  • While those are technically build "steps", since those headers are only shown for plugins, the word "event handlers" (which is specific to plugin build steps) is more appropriate. Also, the word "step" is internal not documented, while we do use the word "event" in our documentation.
  • The plugin name/location should come first, since it is more important.

@ehmicky ehmicky added the type: chore work needed to keep the product and development running smoothly label Oct 12, 2021
@ehmicky ehmicky requested a review from JGAntunes October 12, 2021 12:28
@ehmicky ehmicky self-assigned this Oct 12, 2021
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Oct 12, 2021
Copy link
Contributor

@JGAntunes JGAntunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 wondering if we want to tag this for docs review too?

@ehmicky
Copy link
Contributor Author

ehmicky commented Oct 14, 2021

Yes, good call 👍
cc @KyleBlankRollins

Copy link

@KyleBlankRollins KyleBlankRollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ehmicky, this looks great! And thanks @JGAntunes for tagging me. 😄

I don't have any suggestions. You nailed it. 🔨

@ehmicky ehmicky added automerge and removed type: bug code to address defects in shipped code labels Oct 14, 2021
@kodiakhq kodiakhq bot merged commit e1a33fe into main Oct 14, 2021
@kodiakhq kodiakhq bot deleted the fix/logs-step branch October 14, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants