test: resolve flaky test (macos-14, 22, npm ci, 1) #5984
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request adds or modifies JavaScript ( |
mrstork
changed the title
mrstork
force-pushed
the
investigate-flaky-tests
branch
from
9c6faa7 to
4227a74
Compare
mrstork
changed the title
mrstork
force-pushed
the
investigate-flaky-tests
branch
4 times, most recently
from
84e934a to
081aca9
Compare
mrstork
changed the title
mrstork
force-pushed
the
investigate-flaky-tests
branch
from
ceb8120 to
2bbffdf
Compare
mrstork
force-pushed
the
investigate-flaky-tests
branch
2 times, most recently
from
c599b49 to
f5e0315
Compare
mrstork
force-pushed
the
investigate-flaky-tests
branch
from
f5e0315 to
543ecc5
Compare
mrstork
commented
Jan 2, 2025
| repositoryRoot: packages/build/tests/install/fixtures/yarn_ci␊ | ||
| testOpts:␊ | ||
| pluginsListUrl: test␊ | ||
| silentLingeringProcesses: true␊ | ||
| useBinary: true␊ |
There was a problem hiding this comment.
useBinary was being passed in as a flag instead of altering test setup
mrstork
commented
Jan 2, 2025
| @@ -368,7 +368,7 @@ test('Plugin errors that occur during the loading phase are piped to system logs | |||
| t.snapshot(normalizeOutput(output)) | |||
| }) | |||
|
|
|||
| test('Plugins have a pre-populated Blobs context', async (t) => { | |||
| test.serial('Plugins have a pre-populated Blobs context', async (t) => { | |||
There was a problem hiding this comment.
Due to parallelism, sometimes when calling getPort() by the time the port is used by the test it has been claimed by something else. Making the test run serially is a workaround for this.
|
Wasn't able to get to a resolution. I believe upgrading |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the ava timeouts that have been making our test suite flaky for quite some time now:
(macos-14, 22, npm ci, 1)Timed out while running testsmessage fromavaPredominately followed discussion in
https://github.com/avajs/ava/discussions/3036to get to a resolution