-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: decache all modules #3450
fix: decache all modules #3450
Conversation
📊 Benchmark resultsComparing with db1fd6c Package size: 352 MB(no change)
Legend
|
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Hey Netlify Team, I've applied the changes locally using patch-package as it looks like the prerelease failed to publish. I have good news! my issue is fixed in both my reproduction and my original project! |
GitHub actions is currently having an outage, so the release didn't run through 😅 Great to hear everything works! Thanks for verifying! |
@eduardoboucas please dismiss the review request - I'd like to try writing a reproduction test for this, first. |
- Summary
Closes #3374
In 3374, the bundler rapidly emits
index.js.map
and thenindex.js
. Because we debounce theuncache
call, only the.js.map
file is uncached - but we really wanted to uncacheindex.js
!This PR makes sure that
uncache
is called for every updated file.- Test plan
@mcansh could you validate wether your issue is resolved by updating to
<prerelease version will be inserted here>
?- A picture of a cute animal (not mandatory but encouraged)