Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decache all modules #3450

Merged
merged 5 commits into from
Oct 11, 2021
Merged

fix: decache all modules #3450

merged 5 commits into from
Oct 11, 2021

Conversation

netlify-team-account-1
Copy link
Contributor

@netlify-team-account-1 netlify-team-account-1 commented Oct 5, 2021

- Summary

Closes #3374

In 3374, the bundler rapidly emits index.js.map and then index.js. Because we debounce the uncache call, only the .js.map file is uncached - but we really wanted to uncache index.js!

This PR makes sure that uncache is called for every updated file.

- Test plan

@mcansh could you validate wether your issue is resolved by updating to <prerelease version will be inserted here>?

- A picture of a cute animal (not mandatory but encouraged)

animal watchers

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Oct 5, 2021
@github-actions
Copy link

github-actions bot commented Oct 5, 2021

📊 Benchmark results

Comparing with db1fd6c

Package size: 352 MB

(no change)

^  352 MB  352 MB  352 MB  352 MB  352 MB  352 MB  353 MB  353 MB  353 MB  353 MB  353 MB  353 MB  352 MB 
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

mcansh added a commit to mcansh/remix-on-netlify that referenced this pull request Oct 5, 2021
Signed-off-by: Logan McAnsh <logan@mcan.sh>
mcansh added a commit to mcansh/netlify-require-cache that referenced this pull request Oct 5, 2021
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
Copy link

mcansh commented Oct 5, 2021

Hey Netlify Team, I've applied the changes locally using patch-package as it looks like the prerelease failed to publish. I have good news! my issue is fixed in both my reproduction and my original project!

@netlify-team-account-1
Copy link
Contributor Author

GitHub actions is currently having an outage, so the release didn't run through 😅

Great to hear everything works! Thanks for verifying!

@Skn0tt Skn0tt marked this pull request as draft October 5, 2021 15:27
@netlify-team-account-1
Copy link
Contributor Author

@eduardoboucas please dismiss the review request - I'd like to try writing a reproduction test for this, first.

@netlify-team-account-1 netlify-team-account-1 marked this pull request as ready for review October 11, 2021 09:16
@netlify-team-account-1 netlify-team-account-1 added the automerge Add to Kodiak auto merge queue label Oct 11, 2021
@kodiakhq kodiakhq bot merged commit a1cb1ab into main Oct 11, 2021
@kodiakhq kodiakhq bot deleted the 3374-cached-file-remains branch October 11, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Add to Kodiak auto merge queue type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

netlify dev function not updating
3 participants