Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove NETLIFY_EXPERIMENTAL_BUILD_GO_SOURCE #3504

Merged
merged 2 commits into from
Oct 15, 2021
Merged

feat: remove NETLIFY_EXPERIMENTAL_BUILD_GO_SOURCE #3504

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc015da
feat: remove `NETLIFY_EXPERIMENTAL_BUILD_GO_SOURCE`
eduardoboucas Oct 14, 2021
b1afd73
Merge branch 'main' into feat/remove-go-feature-flag
kodiakhq[bot] Oct 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/commands/functions/create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,14 @@ const { readRepoURL, validateRepoURL } = require('../../utils/read-repo-url')

const templatesDir = path.resolve(__dirname, '../../functions-templates')

const showGoTemplates = process.env.NETLIFY_EXPERIMENTAL_BUILD_GO_SOURCE === 'true'
const showRustTemplates = process.env.NETLIFY_EXPERIMENTAL_BUILD_RUST_SOURCE === 'true'

// Ensure that there's a sub-directory in `src/functions-templates` named after
// each `value` property in this list.
const languages = [
{ name: 'JavaScript', value: 'javascript' },
{ name: 'TypeScript', value: 'typescript' },
showGoTemplates && { name: 'Go', value: 'go' },
{ name: 'Go', value: 'go' },
showRustTemplates && { name: 'Rust', value: 'rust' },
]

Expand Down
2 changes: 1 addition & 1 deletion src/lib/functions/registry.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ class FunctionsRegistry {

const functions = await this.listFunctions(directories, {
featureFlags: {
buildGoSource: env.NETLIFY_EXPERIMENTAL_BUILD_GO_SOURCE === 'true',
buildGoSource: true,
buildRustSource: env.NETLIFY_EXPERIMENTAL_BUILD_RUST_SOURCE === 'true',
},
})
Expand Down
2 changes: 1 addition & 1 deletion tests/serving-functions-go.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ test('Updates a Go function when a file is modified', async (t) => {
await withDevServer(
{
cwd: builder.directory,
env: { ...execaMock, NETLIFY_EXPERIMENTAL_BUILD_GO_SOURCE: 'true' },
env: execaMock,
},
async ({ port, outputBuffer }) => {
await tryAndLogOutput(async () => {
Expand Down