-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: external redirects not being matched correctly closes #3770 #4109
fix: external redirects not being matched correctly closes #3770 #4109
Conversation
While working on the issue, I realized that external redirects don't follow the mentioned status code in the To reproduce, just add a redirects file as follows:
|
Update: Tests aren't failing consistently on all platforms making them hard to debug. |
896f656
to
293a47f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @tinfoil-knight 🚀
Sorry for the delay to review, and appreciate the test case!
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes #3770
External redirects with status code >= 300 & <=400 were not proxied due to requests getting matched incorrectly. This PR fixes the issue by changing the order of matching so that external redirects get matched first.
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.