fix: send analytics on successful commands #4227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with 71950d3 Package size: 508 MB(no change) Legend
|
erezrokah
commented
Feb 8, 2022
| @@ -300,13 +300,14 @@ class BaseCommand extends Command { | |||
| const duration = getDuration(startTime) | |||
| const status = error_ === undefined ? 'success' : 'error' | |||
|
|
|||
| debug(`${this.name()}:onEnd`)(`Status: ${status}`) | |||
| debug(`${this.name()}:onEnd`)(`Duration: ${duration}ms`) | |||
| const command = Array.isArray(this.args) ? this.args[0] : this.name() | |||
There was a problem hiding this comment.
This seems rather defensive, but I rather not have the CLI error if something changes with commander
erezrokah
force-pushed
the
fix/analytics
branch
from
3582efd to
9ee00c7
Compare
erezrokah
commented
Feb 9, 2022
| @@ -49,9 +49,40 @@ test.serial('should track --telemetry-enable', async (t) => { | |||
| test('should send netlify-cli/<version> user-agent', async (t) => { | |||
| await withMockApi(routes, async ({ apiUrl, requests }) => { | |||
| await callCli(['api', 'listSites'], getCLIOptions(apiUrl)) | |||
| t.true(requests.length !== 0) | |||
| const request = requests.find(({ path }) => path === '/api/v1/track') | |||
There was a problem hiding this comment.
This test was failing on my machine as the mock api can receive requests in a different order.
Updated the test to better search the analytics request
erezrokah
force-pushed
the
fix/analytics
branch
from
9ee00c7 to
0adc945
Compare
ehmicky
reviewed
Feb 9, 2022
| program | ||
| .parseAsync(process.argv) | ||
| .then(() => { | ||
| program.onEnd() |
There was a problem hiding this comment.
Note: if onEnd() throws, it will be called twice. Is that ok?
There was a problem hiding this comment.
Great point! I don't see how it can throw
cli/src/commands/base-command.js
Line 298 in c2040bb
We can put everything in onEnd to make it clear that it shouldn't throw, WDYT?
There was a problem hiding this comment.
Yes, it looks pretty safe.
I think it looks good as is 👍
ehmicky
approved these changes
Feb 9, 2022
erezrokah
added
automerge
|
This PR shows a package size of 508MB for some reason. Going to open an issue to investigate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes #4196
Will think on how to test this and add a testDoneFor us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)