Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert typings to .d.ts files #61

Merged
merged 1 commit into from
May 5, 2021
Merged

Conversation

NotWoods
Copy link
Contributor

@NotWoods NotWoods commented May 4, 2021

🎉 Thanks for sending this pull request! 🎉

Please make sure the title is clear and descriptive.

If you are fixing a typo or documentation, please skip these instructions.

Otherwise please fill in the sections below.

Shipping .ts files instead of .d.ts files for TypeScript code that never runs creates issues for some consumers. If there's a typing bug, such as EventPathParameters being unused, there's no way to turn off the error.

I also changed uses of Array to ReadonlyArray, to support returning both normal arrays and the readonly variant.

List other issues or pull requests related to this problem

N/A

Describe the solution you've chosen

By using .d.ts files, consumers can use the skipLibCheck option and ignore type errors from them.

Describe alternatives you've considered

None

Checklist

Please add a x inside each checkbox:

  • I have read the contribution guidelines.
  • The status checks are successful (continuous integration). Those can be seen below.

@NotWoods NotWoods requested a review from a team as a code owner May 4, 2021 20:30
@eduardoboucas eduardoboucas added the type: feature code contributing to the implementation of a feature and/or user facing functionality label May 5, 2021
@eduardoboucas
Copy link
Member

Looks great, thanks!

@eduardoboucas eduardoboucas merged commit f47e83a into netlify:main May 5, 2021
@eduardoboucas
Copy link
Member

This has been released as version 0.7.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants