-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update x/crypto #366
Update x/crypto #366
Conversation
@rybit, I was wondering if you had any suggestions here -- When I ran |
I suspect that the problem is you're building with 1.15 & 1.16: https://github.com/netlify/gotrue/blob/master/.github/workflows/test.yaml#L12 |
Not sure where you're seeing that? I think other than the 1.15 (which won't work it seems) this is going through? |
@rybit ah, I'm not sure why I thought that, but for some reason it seems like the test (1.15.x) step is required to merge, and looking in the
I tried switching it to run for 1.22 instead, but that's when I saw |
I removed the 1.15x requirement and changed it to 1.22. I'm betting that check is so that we can trigger the internal deployment mechanism in that repo. Worth maybe figuring out what those calls are for. idk if you need to make like a matching branch in that repo. |
Thanks for all your help @rybit!! |
- Summary
Fixes: https://github.com/netlify/gotrue/security/dependabot/25
- Test plan
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)