fix: Fix chrome-launcher error preventing reports being generated #573
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #548
This was kind of a weird one to investigate. Initially after having set some additional error logging, I noticed this output:
This led me to believe something had triggered the puppeteer caching issues we've previously seen. However clearing the build cache and retrying led to a different error being logged out reliably:
This would appear to be related to this
chrome-launcher
PR which made thekill()
method no longer return a promise: GoogleChrome/chrome-launcher#269I'm still not 100% sure why some users/repos were being affected by this and not all 🤔 In any case, this feels like a good start and if there are lingering issues hopefully they'll be a bit easier to detect.
Test steps