feat: use Netlify Durable Cache #2510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report 0%↑
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
serhalp
force-pushed
the
serhalp/frp-749-use-durable-cache-directive-in-nextjs-runtime
branch
from
75a601e
to
d75a484
Compare
serhalp
commented
Jun 27, 2024
serhalp
force-pushed
the
serhalp/frp-749-use-durable-cache-directive-in-nextjs-runtime
branch
from
d75a484
to
7c125cb
Compare
serhalp
force-pushed
the
serhalp/frp-749-use-durable-cache-directive-in-nextjs-runtime
branch
from
7c125cb
to
4bd24ff
Compare
serhalp
commented
Jul 3, 2024
tests/e2e/simple-app.test.ts
Outdated
Comment on lines
15
to
17
| expect(headers['cache-status']).toBe('"Next.js"; hit\n"Netlify Edge"; fwd=miss') | ||
| expect(headers['cache-status']).toBe( | ||
| '"Next.js"; hit\n"Netlify Durable"; fwd=miss\n"Netlify Edge"; fwd=miss', | ||
| ) |
There was a problem hiding this comment.
duplicated from #2527 to unblock myself
serhalp
commented
Jul 3, 2024
| @@ -322,6 +322,9 @@ export async function uploadBlobs(ctx: FixtureTestContext, blobsDir: string) { | |||
| ) | |||
| } | |||
|
|
|||
| const DEFAULT_FLAGS = { | |||
| serverless_functions_nextjs_durable_cache_disable: true, | |||
There was a problem hiding this comment.
Since I implemented the flag logic to treat a nullish flag as false (i.e. don't disable Durable Caching, so that we can actually archive the feature flag someday), dozens of integration tests (which were implicitly mocking runtime context.flags to be empty) started failing. This change fixes that, by opting those out of the flag for now.
pieh
approved these changes
Jul 4, 2024
This is gated behind a feature flag for now. I can't link to any public docs yet, but by the time you're reading this you should be able to find a section on "Durable caching" at https://docs.netlify.com.
serhalp
force-pushed
the
serhalp/frp-749-use-durable-cache-directive-in-nextjs-runtime
branch
from
4bd24ff
to
85a5284
Compare
serhalp
deleted the
serhalp/frp-749-use-durable-cache-directive-in-nextjs-runtime
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
👁️🗨️ This will be easier to review commit by commit:
durablecache-control directive if feature flag is enabled for requestThis is gated behind a feature flag for now.
I can't link to any public docs yet, but by the time you're reading this you should be able to find a section on "Durable caching" at https://docs.netlify.com.
Documentation
This functionality is now documented at https://docs.netlify.com/platform/caching/#durable-directive.
Tests
This PR adds exhaustive unit tests and an e2e integration test deployed to a site with the feature flags enabled. I opted not to test through to the platform behavior here since there's no real way to guarantee you're actually hitting separate CDN nodes on subsequent requests and I'd rather not write tests that don't provide confidence in the behavior under test.
You can also manually deploy to that site and manually verify the expected behavior, which I've done.
You can also use this demo site I created: https://github.com/serhalp/next.js-netlify-durable-cache-demo.
Relevant links (GitHub issues, etc.) or a picture of cute animal
FRP-749
Supersedes #2502.