-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image optim plugin #23
Conversation
Hi @chrisdwheatley, This is great! We have updated some things in how Build plugins are built. The new documentation is here. There is also a list of common gotchas here which is helpful to go through. I think this plugin might be using the old format. Do you think it would be possible for you to update it? Thanks a lot for this awesome plugin! |
Thanks, unfortunately I've not had chance to take a look at how things have changed recently but will take a look over the weekend and try to get things up to date. |
Great! Feel free to ask me any questions. |
Hi @chrisdwheatley, I have put up some PRs to help out! :) |
I've updated and tested my plugin based on the changes you PR'd @ehmicky and I've published version The comment I mentioned originally about the readme link is no longer an issue just FYI. |
Thanks @chrisdwheatley! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
This PR adds the image optim plugin to the list of Netlify plugins. It also fixes an issue with the link to the
plugins.json
file not working from the readme.