Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image optim plugin #23

Merged
merged 4 commits into from
May 28, 2020
Merged

Conversation

chrisdwheatley
Copy link
Contributor

This PR adds the image optim plugin to the list of Netlify plugins. It also fixes an issue with the link to the plugins.json file not working from the readme.

@ehmicky
Copy link
Contributor

ehmicky commented Apr 30, 2020

Hi @chrisdwheatley,

This is great!

We have updated some things in how Build plugins are built. The new documentation is here. There is also a list of common gotchas here which is helpful to go through.

I think this plugin might be using the old format. Do you think it would be possible for you to update it? Thanks a lot for this awesome plugin!

@ehmicky ehmicky self-requested a review April 30, 2020 16:33
@ehmicky ehmicky added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Apr 30, 2020
@chrisdwheatley
Copy link
Contributor Author

Thanks, unfortunately I've not had chance to take a look at how things have changed recently but will take a look over the weekend and try to get things up to date.

@ehmicky
Copy link
Contributor

ehmicky commented May 1, 2020

Great! Feel free to ask me any questions.

@ehmicky
Copy link
Contributor

ehmicky commented May 19, 2020

Hi @chrisdwheatley, I have put up some PRs to help out! :)

@chrisdwheatley
Copy link
Contributor Author

I've updated and tested my plugin based on the changes you PR'd @ehmicky and I've published version 0.3.0. Hopefully that covers everything needed to be added to the list :)

The comment I mentioned originally about the readme link is no longer an issue just FYI.

@ehmicky
Copy link
Contributor

ehmicky commented May 28, 2020

Thanks @chrisdwheatley!
This is looking good. This repository's list of files has changed, which seemed to have messed up this PR diff a little. Would it be possible to only include the addition of this plugin to plugins.json.
Thanks!

Copy link
Contributor

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ehmicky ehmicky merged commit 0eb73df into netlify:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants