feat: migrate remix-netlify adapter #83

mcansh · 2023-05-02T20:22:28Z

Description

Related Tickets & Documents

Closes Create a package for the Remix Netlify Functions adapter #82

QA Instructions, Screenshots, Recordings

Note that for the time being, it's expected that the E2E tests fail for a PR from an external contributor. They don't get access to the token to run them. I've checked and they do pass when running manually.

For Serverless Demo

From the root of the project, run npm run build:demo
Run ntl serve to start the serverless demo site.
Run npm run e2e to start up Cypress.
Choose end to end tests from the Cypress UI.
Run the smoke test for the serverless demo site.
All tests pass.

For Edge Demo

From the root of the project, run npm run build:edge-demo
Run ntl serve to start the serverless demo site.
Run npm run e2e to start up Cypress.
Choose end to end tests from the Cypress UI.
Run the smoke test for the serverless demo site.
All tests pass.

For us to review and ship your PR efficiently, please perform the following steps:

Open a bug/issue before writing your code 🧑‍💻. This
ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a
typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
Read the contribution guidelines 📖. This ensures your code follows our style
guide and passes our tests.
Update or add tests (if any source code was changed or added) 🧪
Update or add documentation (if features were changed or added) 📝
Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

Signed-off-by: Logan McAnsh <logan@mcan.sh>

nickytonline · 2023-05-02T21:22:08Z

Thanks for this @mcansh! I already have an E2E test suite for the Netlify Remix Edge Runtime that I can use for this adapter as well.

mcansh · 2023-05-02T21:24:03Z

Thanks for this @mcansh! I already have an E2E test suite for the Netlify Remix Edge Runtime that I can use for this adapter as well.

sweet! i can bring over our current tests too if you'd like

nickytonline · 2023-05-02T21:25:49Z

Thanks for this @mcansh! I already have an E2E test suite for the Netlify Remix Edge Runtime that I can use for this adapter as well.

sweet! i can bring over our current tests too if you'd like

Yeah, the unit tests would be great! Thanks!

not sure what's up with some types, i'll look more into it tomorrow Signed-off-by: Logan McAnsh <logan@mcan.sh>

Signed-off-by: Logan McAnsh <logan@mcan.sh>

nickytonline · 2023-05-03T21:25:07Z

The E2E tests are good, just trying to figure out why when I approve the run for an external contributor it still borks.

Signed-off-by: Logan McAnsh <logan@mcan.sh>

mcansh · 2023-05-04T15:06:42Z

The E2E tests are good, just trying to figure out why when I approve the run for an external contributor it still borks.

maybe it was related to this being a "Draft PR" up until now.

nickytonline · 2023-05-04T21:50:42Z

package.json

@@ -5,6 +5,7 @@
  "main": "index.js",
  "workspaces": [
    "packages/remix-edge-adapter",
+    "packages/remix-serverless-adapter",


naming (blocking): It's explicit, but we've discussed internally before about the name of this whenever we'd get around to it, and we landed on @netlify/remix-adapter

nickytonline · 2023-05-04T21:51:19Z

packages/remix-serverless-adapter/__tests__/binary-types.test.ts

@@ -0,0 +1,12 @@
+import { describe, expect, it } from 'vitest'


thanks for bringing in all the tests! 😍

Signed-off-by: Logan McAnsh <logan@mcan.sh>

packages/remix-adapter/package.json

MichaelDeBoey · 2023-06-13T22:55:57Z

@nickytonline Is there anything that still needs to be done before we can merge this one?

nickytonline · 2023-06-20T20:48:57Z

@nickytonline Is there anything that still needs to be done before we can merge this one?

I've had a few things on the go. Will look to getting this reviewed.

…s-adapter

nickytonline · 2023-07-08T18:48:34Z

@mcansh and @MichaelDeBoey, looking to get this merged next week. I've made a bunch of changes myself, so I can't approve it. I'll let someone on my team do that.

Thanks for the work on this both of you!

packages/demo-site/netlify.toml

packages/demo-site/package.json

packages/remix-adapter/LICENSE

packages/remix-adapter/test/setup.ts

packages/remix-adapter/src/index.ts

packages/demo-site/netlify.toml

Co-authored-by: Michaël De Boey <info@michaeldeboey.be>

…s-adapter

Co-authored-by: Michaël De Boey <info@michaeldeboey.be>

…s-adapter

MarcL

👍🏻 Looks good to me but I'm not a Remix expert!

netlify · 2023-07-19T13:37:30Z

❌ Deploy Preview for hydrogen-demo-site failed.

Name	Link
🔨 Latest commit	`7aae4cc`
🔍 Latest deploy log	https://app.netlify.com/sites/hydrogen-demo-site/deploys/64b7e7eddf8f2a0008790d45

MarcL

…s-adapter

mcansh added 3 commits May 2, 2023 16:21

feat: migrate remix-netlify adapter

13d4c72

Signed-off-by: Logan McAnsh <logan@mcan.sh>

chore: delete our old changelog

e7298f5

Update index.ts

e79d986

mcansh mentioned this pull request May 2, 2023

Create a package for the Remix Netlify Functions adapter #82

Closed

nickytonline assigned nickytonline and unassigned nickytonline May 2, 2023

nickytonline and others added 3 commits May 2, 2023 17:31

chore: trigger build

e4cf57e

test: bring over tests and convert to vitest

172edc6

not sure what's up with some types, i'll look more into it tomorrow Signed-off-by: Logan McAnsh <logan@mcan.sh>

chore: add package to configs

fa35bbc

Signed-off-by: Logan McAnsh <logan@mcan.sh>

mcansh marked this pull request as ready for review May 4, 2023 15:02

mcansh requested a review from a team May 4, 2023 15:02

ci

053afb0

Signed-off-by: Logan McAnsh <logan@mcan.sh>

nickytonline reviewed May 4, 2023

View reviewed changes

mcansh added 2 commits May 4, 2023 17:56

chore: rename

ff150ae

Signed-off-by: Logan McAnsh <logan@mcan.sh>

update package name in package.json

47794ab

MichaelDeBoey approved these changes Jun 13, 2023

View reviewed changes

packages/remix-adapter/package.json Outdated Show resolved Hide resolved

Merge remote-tracking branch 'origin/main' into logan/remix-serverles…

a9adc4d

…s-adapter

nickytonline requested a review from a team as a code owner June 22, 2023 20:43

Merge remote-tracking branch 'origin/main' into logan/remix-serverles…

3575cb8

…s-adapter

This was referenced Jun 28, 2023

Add unit test workflow #113

Closed

chore: added a workflow for unit tests/linting #112

Merged

nickytonline added 2 commits June 28, 2023 17:57

Merge remote-tracking branch 'origin/main' into logan/remix-serverles…

28f2c1a

…s-adapter

Merge branch 'main' into logan/remix-serverless-adapter

6680376

nickytonline added 3 commits July 8, 2023 14:33

chore: remix-adapter package builds on npm prepare now

d51cdd5

chore: added remix-adapter to release please workflow

99260ea

chore: bumped remix-run deps to 1.18.0

dfd591c

MichaelDeBoey suggested changes Jul 9, 2023

View reviewed changes

nickytonline and others added 8 commits July 9, 2023 14:57

Update packages/remix-adapter/LICENSE

f69bca5

Co-authored-by: Michaël De Boey <info@michaeldeboey.be>

Merge remote-tracking branch 'origin/main' into logan/remix-serverles…

ac78c19

…s-adapter

chore: fixed build artifacts location for remix-adapter

922b7f0

Update packages/demo-site/package.json

89ba0df

Co-authored-by: Michaël De Boey <info@michaeldeboey.be>

chore: removed unused deps

a4dc202

Merge remote-tracking branch 'origin/main' into logan/remix-serverles…

2823e59

…s-adapter

chore: upgraded to Remix 1.18.1

489d3c1

chore: added headers that are in the remix repo for the Netlify template

1322d6d

nickytonline self-assigned this Jul 10, 2023

nickytonline added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Jul 10, 2023

chore: added Remix node globals

6bb1e08

MichaelDeBoey approved these changes Jul 10, 2023

View reviewed changes

MarcL previously approved these changes Jul 19, 2023

View reviewed changes

chore: added about route for demo site

b890a9f

nickytonline dismissed MarcL’s stale review via b890a9f July 19, 2023 13:37

MarcL previously approved these changes Jul 19, 2023

View reviewed changes

Merge remote-tracking branch 'origin/main' into logan/remix-serverles…

7aae4cc

…s-adapter

nickytonline dismissed MarcL’s stale review via 7aae4cc July 19, 2023 13:40

MarcL approved these changes Jul 19, 2023

View reviewed changes

nickytonline enabled auto-merge (squash) July 19, 2023 13:45

nickytonline disabled auto-merge July 19, 2023 13:49

nickytonline merged commit cdab2fe into netlify:main Jul 19, 2023

token-generator-app bot mentioned this pull request Jul 19, 2023

chore: release main #142

Merged

mcansh deleted the logan/remix-serverless-adapter branch July 19, 2023 13:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: migrate remix-netlify adapter #83

feat: migrate remix-netlify adapter #83

mcansh commented May 2, 2023 •

edited by nickytonline

Loading

nickytonline commented May 2, 2023

mcansh commented May 2, 2023

nickytonline commented May 2, 2023

nickytonline commented May 3, 2023

mcansh commented May 4, 2023 •

edited

Loading

nickytonline May 4, 2023

nickytonline May 4, 2023

MichaelDeBoey commented Jun 13, 2023

nickytonline commented Jun 20, 2023

nickytonline commented Jul 8, 2023

MarcL left a comment

netlify bot commented Jul 19, 2023 •

edited

Loading

MarcL left a comment

		@@ -0,0 +1,12 @@
		import { describe, expect, it } from 'vitest'

feat: migrate remix-netlify adapter #83

feat: migrate remix-netlify adapter #83

Conversation

mcansh commented May 2, 2023 • edited by nickytonline Loading

Description

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

For Serverless Demo

For Edge Demo

nickytonline commented May 2, 2023

mcansh commented May 2, 2023

nickytonline commented May 2, 2023

nickytonline commented May 3, 2023

mcansh commented May 4, 2023 • edited Loading

nickytonline May 4, 2023

Choose a reason for hiding this comment

nickytonline May 4, 2023

Choose a reason for hiding this comment

MichaelDeBoey commented Jun 13, 2023

nickytonline commented Jun 20, 2023

nickytonline commented Jul 8, 2023

MarcL left a comment

Choose a reason for hiding this comment

netlify bot commented Jul 19, 2023 • edited Loading

❌ Deploy Preview for hydrogen-demo-site failed.

MarcL left a comment

Choose a reason for hiding this comment

mcansh commented May 2, 2023 •

edited by nickytonline

Loading

mcansh commented May 4, 2023 •

edited

Loading

netlify bot commented Jul 19, 2023 •

edited

Loading