Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added a workflow for unit tests/linting #112

Merged
merged 2 commits into from
Jun 28, 2023
Merged

chore: added a workflow for unit tests/linting #112

merged 2 commits into from
Jun 28, 2023

Conversation

nickytonline
Copy link
Contributor

@nickytonline nickytonline commented Jun 28, 2023 •
edited
Loading

Description

Adds a workflow to run unit tests. Required for #83.

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Nothing to do except see the tests go green

Post merge, add this workflow to required checks

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This
    ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a
    typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style
    guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@nickytonline nickytonline force-pushed the nickytonline/add-unit-test-workflow branch from b7812ad to e1213fd Compare June 28, 2023 20:45
@nickytonline nickytonline marked this pull request as ready for review June 28, 2023 20:48
@nickytonline nickytonline requested a review from a team as a code owner June 28, 2023 20:48
@nickytonline nickytonline changed the title nickytonline/add unit test workflow chore: added a workflow for unit test/linting Jun 28, 2023
@github-actions github-actions bot added the type: chore work needed to keep the product and development running smoothly label Jun 28, 2023
@nickytonline nickytonline self-assigned this Jun 28, 2023
@nickytonline nickytonline changed the title chore: added a workflow for unit test/linting chore: added a workflow for unit tests/linting Jun 28, 2023
@nickytonline nickytonline added the automerge so Kodiak can automatically merge label Jun 28, 2023
@kodiakhq kodiakhq bot merged commit abeb18c into main Jun 28, 2023
@kodiakhq kodiakhq bot deleted the nickytonline/add-unit-test-workflow branch June 28, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taty2010 taty2010 taty2010 approved these changes

Assignees

@nickytonline nickytonline

Labels
automerge so Kodiak can automatically merge type: chore work needed to keep the product and development running smoothly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unit test workflow
2 participants
@nickytonline @taty2010