fix(@netlify/remix-edge-adapter): don't close the stream twice

[pieh]

Description

Fixes TypeError: Closed already requested that started to be thrown with deno@1.43.0. Suspected underlying reason for change is denoland/deno#23425 and now we receive abort signal after all the work was already completed and response stream is being attempted to close twice (?).

TBF, this feels weird that ReactDOMServer.renderToReadableStream doesn't handle this in some way to prevent closing stream multiple times. I needed to do tricks with identity TransformStream to figure out state of the stream and prevent signal from resulting in the error.

Alternatives to current fix are those (one of them):

• don't pass signal to ReactDOMServer.renderToReadableStream at all (feels wasteful not to be able to abort on demand)
• just ... don't log those errors ( https://github.com/denoland/deno/blob/b01578ae1fc1da65ac38daec31a23c9ef652aa74/ext/web/06_streams.js#L5849 ) - logs we see come from our own console.error in our onError handler so we could filter those out (which would be hacky because it would mean checking error message that is subject to change)

Edit:
There is also another error happening (or have been happening):

ReadableByteStreamController's stream is not in a readable state

Which I can't reproduce and also am not seeing it in logs for currently deployed demo site, it's unclear to me wether they are related or not (other than this is can thrown also when attempting to close the stream - https://github.com/denoland/deno/blob/b01578ae1fc1da65ac38daec31a23c9ef652aa74/ext/web/06_streams.js#L5845-L5857 )

Related Tickets & Documents

• Related Issue #
• Closes #

QA Instructions, Screenshots, Recordings

Compare logs from:

• main - https://app.netlify.com/sites/remix-edge/logs/edge-functions?scope=deployid:66d53a37e9d7480008ad1daf when hitting https://66d53a37e9d7480008ad1daf--remix-edge.netlify.app/
• changes in this PR - https://app.netlify.com/sites/remix-edge/logs/edge-functions?scope=deployid:66d97d0885845c0008b39ed1 when hitting https://66d97d0885845c0008b39ed1--remix-edge.netlify.app/

There are no error logs produced anymore for each request

For us to review and ship your PR efficiently, please perform the following steps:

• Open a bug/issue before writing your code 🧑‍💻. This
  ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a
  typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
• Read the contribution guidelines 📖. This ensures your code follows our style
  guide and passes our tests.
• Update or add tests (if any source code was changed or added) 🧪
• Update or add documentation (if features were changed or added) 📝
• Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

[netlify]

✅ Deploy Preview for remix-edge ready!

Name	Link
🔨 Latest commit	4f5d760
🔍 Latest deploy log	https://app.netlify.com/sites/remix-edge/deploys/66d9f6c937a5e10008c43e5c
😎 Deploy Preview	https://deploy-preview-444--remix-edge.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[netlify]

✅ Deploy Preview for remix-serverless ready!

Name	Link
🔨 Latest commit	4f5d760
🔍 Latest deploy log	https://app.netlify.com/sites/remix-serverless/deploys/66d9f6c91b08ab00081b2600
😎 Deploy Preview	https://deploy-preview-444--remix-serverless.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[orinokai]

As you say, it's odd that this isn't handled in some way by React - but this solution preserves the handling of abort and doesn't introduce much complexity, so lgtm

[serhalp]

Thanks for fixing!