[draft] react-router 7 support #471
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for remix-serverless failed. Why did it fail? →
|
✅ Deploy Preview for remix-edge ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mrstork
commented
Nov 28, 2024
Comment on lines
+3
to
+5
| Copyright (c) Remix Software Inc. 2020-2021 | ||
| Copyright (c) Shopify Inc. 2022-2023 | ||
| Copyright (c) Netlify Inc. 2023 |
There was a problem hiding this comment.
- Update License messaging
mrstork
commented
Nov 28, 2024
Comment on lines
+6
to
+9
| <!-- TODO update this with react router template --> | ||
| <!-- It is strongly advised to use [the Netlify Remix template](https://github.com/netlify/remix-template) to create a Remix | ||
| site for deployment to Netlify. See [Remix on Netlify](https://docs.netlify.com/frameworks/remix/) for more details and | ||
| other options. --> |
There was a problem hiding this comment.
- Update with reference to react router template
mrstork
commented
Nov 28, 2024
| }, | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/netlify/remix-compute", |
There was a problem hiding this comment.
- Decide if we're keeping the react-router adapter in this repository
mrstork
commented
Nov 28, 2024
Comment on lines
+56
to
+64
| // We need to add an extra SSR entrypoint, as we need to compile | ||
| // the server entrypoint too. This is because it uses virtual | ||
| // modules. | ||
| // NOTE: the below is making various assumptions about the React Router Vite plugin's | ||
| // implementation details: | ||
| // https://github.com/remix-run/remix/blob/cc65962b1a96d1e134336aa9620ef1dad7c5efb1/packages/remix-dev/vite/plugin.ts#L1149-L1168 | ||
| // TODO(serhalp) Stop making these assumptions or assert them explictly. | ||
| // TODO(serhalp) Unless I'm misunderstanding something, we should only need to *replace* | ||
| // the default React Router Vite SSR entrypoint, not add an additional one. |
There was a problem hiding this comment.
- We should try to simplify this comment if possible (also applies to the remix-adapter as this was copied over)
mrstork
commented
Nov 28, 2024
| const start = Date.now() | ||
| console.log(`[${request.method}] ${request.url}`) | ||
| try { | ||
| const mergedLoadContext = (await getLoadContext?.(request, netlifyContext)) || netlifyContext |
There was a problem hiding this comment.
@serhalp - I renamed this to mergedLoadContext, is that reasonable?
mrstork
commented
Nov 28, 2024
| @@ -0,0 +1,66 @@ | |||
| # Changelog | |||
There was a problem hiding this comment.
- Clear runtime changelog
mrstork
commented
Nov 28, 2024
| @@ -0,0 +1,11 @@ | |||
| # Remix Server Runtime for Netlify | |||
There was a problem hiding this comment.
- Remix in runtime readme
mrstork
commented
Nov 28, 2024
| }, | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "git+https://github.com/netlify/remix-compute.git" |
There was a problem hiding this comment.
- Are we keeping the runtime in the remix-compute repository? (repeat)
|
Replaced by #472 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tested https://github.com/remix-run/react-router-templates/tree/main/default with
ntl dev+ntl serve+ntl deployand they all seem to work well. Edge was not tested.Notes:
react-router-adapterbut this is meant to serve as a starting point for usvite.Plugintypereact-router-runtimeas I've done here, however it is worth noting that the following variables are not currently exported from@react-router/server-runtimebroadcastDevReadylogDevReadyUNSAFE_SingleFetchRedirectSymbolUNSAFE_SingleFetchResultsUNSAFE_SingleFetchResultreact-router-adapterto its own repository, or keep it here for the time being?TODO:
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes
For us to review and ship your PR efficiently, please perform the following steps:
ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a
typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)