-
Notifications
You must be signed in to change notification settings - Fork 554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Couple of issues, one of which is breaking the build. I can review again once addressed and a deploy preview is live.
scripts/fetch-archive.js
Outdated
reject(error); | ||
}); | ||
}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could shrink this a lot by using fetch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you already have this as a dependency or do I need to add node-fetch
?
scripts/fetch-archive.js
Outdated
const npmPackageData = await getAllProjectPackageSizes(npms); | ||
|
||
const data = projects.reduce((obj, { key, repo, npm, twitter }) => { | ||
const twitterData = twitter ? { followers: twitterFollowers[twitter] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing the or
case for this ternary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I was falling asleep while writing this and couldn't figure out what I did wrong haha. I'll fix this when I get home.
I actually wouldn't put this metric in the stats, maybe a "Package size" item in the list below? |
That was my first thought too but I don't know how to put it in the list below 😅 I just see the |
It's actually pulled straight from the individual project frontmatters: Line 19 in acf13dc
Lines 155 to 161 in acf13dc
It doesn't have to be just frontmatter though, you can add your data to the fields array right there in |
Ok I see where |
Right here: Line 103 in acf13dc
I'd say create a new To get your values into Line 88 in acf13dc
|
Ok I tried a couple things but I'm still stuck 😭 |
Hey @styfle, just now circling back to this. I don't have much bandwidth to dig in - do you still plan on working on this? |
Oops, I almost forgot about it 😅 |
@styfle closing this, but feel free to reopen if you ever circle back! |
Fixes #359