feat: add traceWithNft feature flag (#769)

* feat: add aws-sdk to NFT ignore

* feat: add traceWithNft flag

* fix: make path Windows-friendly

* fix: make ignore function compatible with Windows paths

* refactor: adjust ignore glob

src/feature_flags.ts

@@ -5,6 +5,7 @@ const FLAGS: Record<string, boolean> = {
   buildRustSource: Boolean(env.NETLIFY_EXPERIMENTAL_BUILD_RUST_SOURCE),
   defaultEsModulesToEsbuild: Boolean(env.NETLIFY_EXPERIMENTAL_DEFAULT_ES_MODULES_TO_ESBUILD),
   parseWithEsbuild: false,
+  traceWithNft: false,
 }
 
 type FeatureFlag = keyof typeof FLAGS

src/runtimes/node/bundlers/nft/index.ts

@@ -2,6 +2,8 @@ import { basename, dirname, join, normalize, resolve } from 'path'
 
 import { nodeFileTrace } from '@vercel/nft'
 import resolveDependency from '@vercel/nft/out/resolve-dependency'
+import minimatch from 'minimatch'
+import unixify from 'unixify'
 
 import type { BundleFunction } from '..'
 import type { FunctionConfig } from '../../../../config'
@@ -12,6 +14,9 @@ import { filterExcludedPaths, getPathsOfIncludedFiles } from '../../utils/includ
 
 import { transpileMany } from './transpile'
 
+// Paths that will be excluded from the tracing process.
+const ignore = ['node_modules/aws-sdk/**']
+
 interface NftCache {
   analysisCache?: Map<string, { isESM: boolean; [key: string]: unknown }>
   [key: string]: unknown
@@ -54,6 +59,13 @@ const bundle: BundleFunction = async ({
   }
 }
 
+const ignoreFunction = (path: string) => {
+  const normalizedPath = unixify(path)
+  const shouldIgnore = ignore.some((expression) => minimatch(normalizedPath, expression))
+
+  return shouldIgnore
+}
+
 const traceFilesAndTranspile = async function ({
   basePath,
   config,
@@ -70,6 +82,7 @@ const traceFilesAndTranspile = async function ({
   const { fileList: dependencyPaths } = await nodeFileTrace([mainFile], {
     base: basePath,
     cache,
+    ignore: ignoreFunction,
     readFile: async (path: string) => {
       try {
         const source = (await cachedReadFile(fsCache, path, 'utf8')) as string
@@ -136,7 +149,7 @@ const getSrcFiles: GetSrcFilesFunction = async function ({ basePath, config, mai
     includedFiles,
     includedFilesBasePath,
   )
-  const { fileList: dependencyPaths } = await nodeFileTrace([mainFile], { base: basePath })
+  const { fileList: dependencyPaths } = await nodeFileTrace([mainFile], { base: basePath, ignore: ignoreFunction })
   const normalizedDependencyPaths = dependencyPaths.map((path) => (basePath ? resolve(basePath, path) : resolve(path)))
   const includedPaths = filterExcludedPaths([...normalizedDependencyPaths, ...includedFilePaths], excludedPaths)
 

src/runtimes/node/index.ts

@@ -23,11 +23,17 @@ const getDefaultBundler = async ({
   mainFile: string
   featureFlags: FeatureFlags
 }): Promise<NodeBundlerName> => {
+  const { defaultEsModulesToEsbuild, traceWithNft } = featureFlags
+
   if (['.mjs', '.ts'].includes(extension)) {
     return 'esbuild'
   }
 
-  if (featureFlags.defaultEsModulesToEsbuild) {
+  if (traceWithNft) {
+    return 'nft'
+  }
+
+  if (defaultEsModulesToEsbuild) {
     const isEsModule = await detectEsModule({ mainFile })
 
     if (isEsModule) {

tests/helpers/test_many.js

@@ -46,7 +46,7 @@ const makeTestMany = (test, matrix) => {
 
       const rateLimitedTestFn = getRateLimitedTestFunction(testFn)
 
-      rateLimitedTestFn(testTitle, assertions.bind(null, variation))
+      rateLimitedTestFn(testTitle, assertions.bind(null, variation), name)
     })
   }