Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Commit

Permalink
chore: unzip every function into their own folder in tests (#1420)
Browse files Browse the repository at this point in the history
* chore: unzip every function into their own folder in tests

* chore: simplify list functions tests

* chore: fix tests

* chore: fix windows tests

* chore: changes

* chore: assert that zip file exists

* chore: test

* chore: simplify
  • Loading branch information
danez authored May 11, 2023
1 parent fd08f96 commit fd7225f
Show file tree
Hide file tree
Showing 14 changed files with 1,634 additions and 845 deletions.
82 changes: 0 additions & 82 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,7 @@
"husky": "^8.0.0",
"lambda-local": "^2.0.3",
"npm-run-all": "^4.1.5",
"sort-on": "^5.0.0",
"source-map-support": "^0.5.21",
"throat": "^6.0.1",
"typescript": "^5.0.0",
"vite": "^4.0.0",
"vitest": "^0.31.0"
Expand Down
2 changes: 1 addition & 1 deletion src/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ export const listFunctionsFiles = async function (
featureFlags: inputFeatureFlags,
parseISC = false,
}: ListFunctionsOptions = {},
) {
): Promise<ListedFunctionFile[]> {
const featureFlags = getFlags(inputFeatureFlags)
const srcFolders = resolveFunctionsDirectories(relativeSrcFolders)
const paths = await listFunctionsDirectories(srcFolders)
Expand Down
121 changes: 121 additions & 0 deletions tests/__snapshots__/list_functions.test.ts.snap
Original file line number Diff line number Diff line change
@@ -0,0 +1,121 @@
// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html

exports[`listFunctions > Can list function main files from multiple source directories with listFunctions() 1`] = `
[
{
"displayName": undefined,
"extension": ".js",
"generator": undefined,
"mainFile": ".netlify/internal-functions/function.js",
"name": "function",
"runtime": "js",
"schedule": undefined,
"srcFile": undefined,
},
{
"displayName": undefined,
"extension": ".js",
"generator": undefined,
"mainFile": ".netlify/internal-functions/function_internal.js",
"name": "function_internal",
"runtime": "js",
"schedule": undefined,
"srcFile": undefined,
},
{
"displayName": undefined,
"extension": ".js",
"generator": undefined,
"mainFile": "netlify/functions/function.js",
"name": "function",
"runtime": "js",
"schedule": undefined,
"srcFile": undefined,
},
{
"displayName": undefined,
"extension": ".js",
"generator": undefined,
"mainFile": "netlify/functions/function_user.js",
"name": "function_user",
"runtime": "js",
"schedule": undefined,
"srcFile": undefined,
},
]
`;

exports[`listFunctions > Can list function main files with listFunctions() 1`] = `
[
{
"displayName": undefined,
"extension": ".zip",
"generator": undefined,
"mainFile": "test.zip",
"name": "test",
"runtime": "js",
"schedule": undefined,
"srcFile": undefined,
},
{
"displayName": undefined,
"extension": ".js",
"generator": undefined,
"mainFile": "test.js",
"name": "test",
"runtime": "js",
"schedule": undefined,
"srcFile": undefined,
},
{
"displayName": undefined,
"extension": ".ts",
"generator": undefined,
"mainFile": "five/index.ts",
"name": "five",
"runtime": "js",
"schedule": undefined,
"srcFile": undefined,
},
{
"displayName": undefined,
"extension": ".js",
"generator": undefined,
"mainFile": "four.js/four.js.js",
"name": "four",
"runtime": "js",
"schedule": undefined,
"srcFile": undefined,
},
{
"displayName": undefined,
"extension": ".js",
"generator": undefined,
"mainFile": "one/index.js",
"name": "one",
"runtime": "js",
"schedule": undefined,
"srcFile": undefined,
},
{
"displayName": undefined,
"extension": ".js",
"generator": undefined,
"mainFile": "two/two.js",
"name": "two",
"runtime": "js",
"schedule": undefined,
"srcFile": undefined,
},
{
"displayName": undefined,
"extension": "",
"generator": undefined,
"mainFile": "test",
"name": "test",
"runtime": "go",
"schedule": undefined,
"srcFile": undefined,
},
]
`;
Loading

1 comment on commit fd7225f

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏱ Benchmark results

  • largeDepsEsbuild: 2.2s
  • largeDepsNft: 7.7s
  • largeDepsZisi: 15.2s

Please sign in to comment.