Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

feat: update node version to 18 #1444

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

biruwon
Copy link
Contributor

@biruwon biruwon commented May 29, 2023

🎉 Thanks for submitting a pull request! 🎉

Summary

This is a copy of the past PR

Fixes the update for node js version to 18

I found another usage of node 16 in here, but updating it breaks the tests. Does anyone knows why?


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻.
    This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing
    a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@biruwon biruwon requested a review from a team May 29, 2023 09:11
@biruwon biruwon self-assigned this May 29, 2023
@biruwon biruwon requested a review from a team as a code owner May 29, 2023 09:12
@github-actions
Copy link
Contributor

github-actions bot commented May 29, 2023

⏱ Benchmark results

Comparing with 909a22a

largeDepsEsbuild: 2.6s

⬇️ 12.80% decrease vs. 909a22a

^   2.9s                                                                            2.9s          
│   ┌──┐                                                            2.7s            ┌──┐          
│   |  |                                    2.6s    2.6s            ┌──┐            |  |    2.6s  
│   |  |                                    ┌──┐    ┌──┐            |  |            |  |    ┌──┐  
│ ──┼──┼────────────────────────────────────┼──┼────┼──┼────────────┼──┼────────────┼──┼────|▒▒|──
│   |  |            2.2s            2.2s    |  |    |  |    2.2s    |  |            |  |    |▒▒|  
│   |  |     2s     ┌──┐     2s     ┌──┐    |  |    |  |    ┌──┐    |  |    2.1s    |  |    |▒▒|  
│   |  |    ┌──┐    |  |    ┌──┐    |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

largeDepsNft: 9.7s

⬇️ 12.49% decrease vs. 909a22a

^  11.4s                                                                                          
│   ┌──┐                                                           10.6s            11s           
│   |  |                                                            ┌──┐            ┌──┐          
│   |  |                                                            |  |            |  |    9.7s  
│   |  |                                     9s     9.1s            |  |            |  |    ┌──┐  
│   |  |                                    ┌──┐    ┌──┐            |  |            |  |    |▒▒|  
│ ──┼──┼────────────7.7s────────────────────┼──┼────┼──┼────7.8s────┼──┼────────────┼──┼────|▒▒|──
│   |  |            ┌──┐            7.6s    |  |    |  |    ┌──┐    |  |    7.3s    |  |    |▒▒|  
│   |  |    6.8s    |  |    6.9s    ┌──┐    |  |    |  |    |  |    |  |    ┌──┐    |  |    |▒▒|  
│   |  |    ┌──┐    |  |    ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

largeDepsZisi: 18.1s

⬇️ 12.14% decrease vs. 909a22a

^  20.8s                                                                                          
│   ┌──┐                                                           19.8s           20.3s          
│   |  |                                           18.7s            ┌──┐            ┌──┐          
│   |  |                                            ┌──┐            |  |            |  |   18.1s  
│   |  |                                   17.1s    |  |            |  |            |  |    ┌──┐  
│ ──┼──┼────────────────────────────────────┌──┐────┼──┼───15.4s────┼──┼────────────┼──┼────|▒▒|──
│   |  |           14.9s            15s     |  |    |  |    ┌──┐    |  |            |  |    |▒▒|  
│   |  |   13.8s    ┌──┐   13.9s    ┌──┐    |  |    |  |    |  |    |  |   13.9s    |  |    |▒▒|  
│   |  |    ┌──┐    |  |    ┌──┐    |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

@eduardoboucas
Copy link
Member

I found another usage of node 16 in here, but updating it breaks the tests. Does anyone knows why?

That controls which version of Node we "compile" the package itself, which is independent from the version of Node we use in the functions the package generates. So I don't think we should be changing that as part of this PR.

@biruwon biruwon enabled auto-merge (squash) June 1, 2023 09:37
@biruwon biruwon merged commit 881a185 into main Jun 1, 2023
@biruwon biruwon deleted the antonio/update-default-node-version-to-node-18 branch June 1, 2023 09:41
Skn0tt pushed a commit to netlify/build that referenced this pull request May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants