feat: expose the api version in the results #1460

danez · 2023-06-12T14:55:11Z

Summary

Expose the property runtimeAPIVersion in the result of zip* and list* methods

This property has multiple meanings:

list*
- undefined: we do not know, because we did not check/parse the file or there was a parsing error
- 2: we detected version 2
- 1: not detected version 2
zip*
- undefined: something went wrong, parsing error etc.
- 2: we detected version 2
- 1: not detected version 2

The diff is best viewed with whitespace diffing off :D

github-actions · 2023-06-12T14:57:11Z

⏱ Benchmark results

Comparing with 418a420

largeDepsEsbuild: 2.9s

⬇️ 4.54% decrease vs. 418a420

^                                                           3.5s                                          
│                                                           ┌──┐                                          
│                                                           |  |                                          
│   2.9s                                                    |  |                             3s           
│   ┌──┐                                    2.9s            |  |                            ┌──┐    2.9s  
│   |  |                    2.7s            ┌──┐    2.6s    |  |    2.6s    2.6s            |  |    ┌──┐  
│ ──┼──┼────2.4s────────────┌──┐────────────┼──┼────┌──┐────┼──┼────┌──┐────┌──┐────2.5s────┼──┼────|▒▒|──
│   |  |    ┌──┐            |  |            |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |▒▒|  
│   |  |    |  |     2s     |  |     2s     |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    ┌──┐    |  |    ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-25 (7bf9bc9): 2.9s
T-24 (ffd786d): 2s
T-23 (4962361): 2.2s
T-22 (94eb5e6): 2s
T-21 (5a982c9): 2.2s
T-20 (8755797): 2.6s
T-19 (2c31885): 2.6s
T-18 (271729d): 2.2s
T-17 (e34c7f7): 2.7s
T-16 (208671c): 2.1s
T-15 (909a22a): 2.9s
T-14 (881a185): 2.2s
T-13 (9036fc4): 2.5s
T-12 (d4393a8): 2.9s
T-11 (3212f41): 2.4s
T-10 (f303673): 2s
T-9 (4b53ea3): 2.7s
T-8 (2a674c3): 2s
T-7 (2c98796): 2.9s
T-6 (d15f50b): 2.6s
T-5 (cf43a33): 3.5s
T-4 (5c85398): 2.6s
T-3 (16e49d9): 2.6s
T-2 (47c0b97): 2.5s
T-1 (418a420): 3s
T (current commit): 2.9s

largeDepsNft: 9.4s

⬇️ 1.34% decrease vs. 418a420

^                                                          12.1s                                          
│                                                           ┌──┐                                          
│  10.9s                                                    |  |                                          
│   ┌──┐                    10s            10.6s            |  |                                          
│   |  |                    ┌──┐            ┌──┐            |  |                            9.6s    9.4s  
│   |  |    8.7s            |  |            |  |            |  |                            ┌──┐    ┌──┐  
│ ──┼──┼────┌──┐────────────┼──┼────────────┼──┼────────────┼──┼────────────────────────────┼──┼────|▒▒|──
│   |  |    |  |            |  |            |  |    8.1s    |  |     8s     8.1s    8.1s    |  |    |▒▒|  
│   |  |    |  |    7.1s    |  |            |  |    ┌──┐    |  |    ┌──┐    ┌──┐    ┌──┐    |  |    |▒▒|  
│   |  |    |  |    ┌──┐    |  |    6.9s    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-25 (7bf9bc9): 11.4s
T-24 (ffd786d): 6.8s
T-23 (4962361): 7.7s
T-22 (94eb5e6): 6.9s
T-21 (5a982c9): 7.6s
T-20 (8755797): 9s
T-19 (2c31885): 9.1s
T-18 (271729d): 7.8s
T-17 (e34c7f7): 10.6s
T-16 (208671c): 7.3s
T-15 (909a22a): 11s
T-14 (881a185): 8.2s
T-13 (9036fc4): 9.2s
T-12 (d4393a8): 10.9s
T-11 (3212f41): 8.7s
T-10 (f303673): 7.1s
T-9 (4b53ea3): 10s
T-8 (2a674c3): 6.9s
T-7 (2c98796): 10.6s
T-6 (d15f50b): 8.1s
T-5 (cf43a33): 12.1s
T-4 (5c85398): 8s
T-3 (16e49d9): 8.1s
T-2 (47c0b97): 8.1s
T-1 (418a420): 9.6s
T (current commit): 9.4s

largeDepsZisi: 18.1s

⬇️ 3.15% decrease vs. 418a420

^                                                          22.5s                                          
│                                                           ┌──┐                                          
│  20.4s                                   20.5s            |  |                                          
│   ┌──┐                   18.7s            ┌──┐            |  |                           18.7s          
│   |  |                    ┌──┐            |  |            |  |                            ┌──┐   18.1s  
│ ──┼──┼───17.4s────────────┼──┼────────────┼──┼────────────┼──┼────────────────────────────┼──┼────┌──┐──
│   |  |    ┌──┐            |  |            |  |   15.9s    |  |    16s     16s    16.2s    |  |    |▒▒|  
│   |  |    |  |   14.1s    |  |            |  |    ┌──┐    |  |    ┌──┐    ┌──┐    ┌──┐    |  |    |▒▒|  
│   |  |    |  |    ┌──┐    |  |    14s     |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-25 (7bf9bc9): 20.8s
T-24 (ffd786d): 13.8s
T-23 (4962361): 14.9s
T-22 (94eb5e6): 13.9s
T-21 (5a982c9): 15s
T-20 (8755797): 17.1s
T-19 (2c31885): 18.7s
T-18 (271729d): 15.4s
T-17 (e34c7f7): 19.8s
T-16 (208671c): 13.9s
T-15 (909a22a): 20.3s
T-14 (881a185): 15.3s
T-13 (9036fc4): 17s
T-12 (d4393a8): 20.4s
T-11 (3212f41): 17.4s
T-10 (f303673): 14.1s
T-9 (4b53ea3): 18.7s
T-8 (2a674c3): 14s
T-7 (2c98796): 20.5s
T-6 (d15f50b): 15.9s
T-5 (cf43a33): 22.5s
T-4 (5c85398): 16s
T-3 (16e49d9): 16s
T-2 (47c0b97): 16.2s
T-1 (418a420): 18.7s
T (current commit): 18.1s

danez · 2023-06-12T16:02:54Z

README.md

+
+  Which exact runtime this function should be using. (e.g. `nodejs18.x`). This value is detected based on the input
+  `nodeVersion`.
+


These are the only two actual changes in this file, the rest is formatting from prettier.

runtimeVersion was introduced in #1367, but never documented

danez · 2023-06-12T16:03:43Z

src/main.ts

    schedule: inSourceConfig?.schedule ?? config.schedule,
-    generator: config.generator,


sorting + runtimeAPIVersion added :)

Skn0tt

Looks good, especially the broad test coverage! Left a small comment.

src/utils/format_result.ts

…it#1460)

danez added the Ecosystem: Dev Foundations label Jun 12, 2023

danez self-assigned this Jun 12, 2023

danez requested a review from a team as a code owner June 12, 2023 14:55

danez force-pushed the apiversion branch from ad37101 to 9586c3d Compare June 12, 2023 15:31

feat: expose the api version in the results

8f6e6b7

danez force-pushed the apiversion branch from 9586c3d to 8f6e6b7 Compare June 12, 2023 15:54

danez commented Jun 12, 2023

View reviewed changes

Skn0tt approved these changes Jun 13, 2023

View reviewed changes

src/utils/format_result.ts Show resolved Hide resolved

Merge branch 'main' into apiversion

e51b38f

danez merged commit bae1ee5 into main Jun 13, 2023

danez deleted the apiversion branch June 13, 2023 09:22

token-generator-app bot mentioned this pull request Jun 13, 2023

chore(main): release 9.9.0 #1463

Merged

Skn0tt pushed a commit to netlify/build that referenced this pull request May 21, 2024

feat: expose the api version in the results (netlify/zip-it-and-ship-…

e570403

…it#1460)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: expose the api version in the results #1460

feat: expose the api version in the results #1460

danez commented Jun 12, 2023 •

edited

Loading

github-actions bot commented Jun 12, 2023 •

edited

Loading

danez Jun 12, 2023

danez Jun 12, 2023

Skn0tt left a comment


		Which exact runtime this function should be using. (e.g. `nodejs18.x`). This value is detected based on the input
		`nodeVersion`.

		schedule: inSourceConfig?.schedule ?? config.schedule,
		generator: config.generator,

feat: expose the api version in the results #1460

feat: expose the api version in the results #1460

Conversation

danez commented Jun 12, 2023 • edited Loading

Summary

github-actions bot commented Jun 12, 2023 • edited Loading

⏱ Benchmark results

largeDepsEsbuild: 2.9s

largeDepsNft: 9.4s

largeDepsZisi: 18.1s

danez Jun 12, 2023

Choose a reason for hiding this comment

danez Jun 12, 2023

Choose a reason for hiding this comment

Skn0tt left a comment

Choose a reason for hiding this comment

danez commented Jun 12, 2023 •

edited

Loading

github-actions bot commented Jun 12, 2023 •

edited

Loading