fix: fixes an issue where the included paths where missing symlinks and .dot directories #1678

lukasholzer · 2023-12-01T11:52:34Z

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes an issue where with pnpm the included files did not copy over the node_modules correctly as it was not preserving symlinks and not copying over dot directories.

Tested and verified with the next runtime

For us to review and ship your PR efficiently, please perform the following steps:

Open a bug/issue before writing your code 🧑‍💻.
This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing
a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
Read the contribution guidelines 📖. This ensures your code follows our style guide and
passes our tests.
Update or add tests (if any source code was changed or added) 🧪
Update or add documentation (if features were changed or added) 📝
Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

…nd .dot directories

github-actions · 2023-12-01T11:54:08Z

⏱ Benchmark results

Comparing with bc7b0b8

largeDepsEsbuild: 1.4s

⬇️ 2.92% decrease vs. bc7b0b8

^   1.5s    1.4s                                            1.5s    1.5s                    1.5s          
│   ┌──┐    ┌──┐    1.4s    1.4s    1.4s    1.4s    1.4s    ┌──┐    ┌──┐    1.4s    1.4s    ┌──┐    1.4s  
│ ──┼──┼────┼──┼────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┼──┼────┼──┼────┌──┐────┌──┐────┼──┼────┌──┐──
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (cacee3f): 2.7s
T-29 (52a6654): 3.5s
T-28 (c0b0b7a): 2.7s
T-27 (15399f4): 2.7s
T-26 (ac5532d): 2.7s
T-25 (e4d0ba9): 1.5s
T-24 (234379a): 1.5s
T-23 (5fc5321): 1.5s
T-22 (fee5d2e): 1.5s
T-21 (b8a39b6): 2.6s
T-20 (06ef08f): 1.4s
T-19 (c0a64fc): 1.5s
T-18 (bcb0388): 1.5s
T-17 (5ca965f): 1.4s
T-16 (46c96e2): 1.5s
T-15 (145bc5f): 1.5s
T-14 (8ac5b33): 1.5s
T-13 (fd6c7e6): 1.4s
T-12 (1c7ce98): 1.5s
T-11 (d40e8dd): 1.4s
T-10 (dc6d7a5): 1.4s
T-9 (31faa09): 1.4s
T-8 (0f23aa8): 1.4s
T-7 (e151134): 1.4s
T-6 (f5fb309): 1.4s
T-5 (cff8955): 1.5s
T-4 (be424b2): 1.5s
T-3 (f146798): 1.4s
T-2 (c7901aa): 1.4s
T-1 (bc7b0b8): 1.5s
T (current commit): 1.4s

largeDepsNft: 5.5s

⬇️ 1.71% decrease vs. bc7b0b8

^                                                                   5.8s                                  
│   5.5s    5.6s    5.5s    5.5s    5.6s            5.4s    5.5s    ┌──┐    5.5s    5.5s    5.6s    5.5s  
│ ──┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────5.4s────┌──┐────┌──┐────┼──┼────┌──┐────┌──┐────┌──┐────┌──┐──
│   |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (cacee3f): 8.7s
T-29 (52a6654): 11.1s
T-28 (c0b0b7a): 8.5s
T-27 (15399f4): 8.2s
T-26 (ac5532d): 8.5s
T-25 (e4d0ba9): 5.5s
T-24 (234379a): 5.6s
T-23 (5fc5321): 5.6s
T-22 (fee5d2e): 5.7s
T-21 (b8a39b6): 8.1s
T-20 (06ef08f): 5.5s
T-19 (c0a64fc): 5.6s
T-18 (bcb0388): 5.5s
T-17 (5ca965f): 5.5s
T-16 (46c96e2): 5.5s
T-15 (145bc5f): 5.5s
T-14 (8ac5b33): 5.6s
T-13 (fd6c7e6): 5.5s
T-12 (1c7ce98): 5.5s
T-11 (d40e8dd): 5.6s
T-10 (dc6d7a5): 5.5s
T-9 (31faa09): 5.5s
T-8 (0f23aa8): 5.6s
T-7 (e151134): 5.4s
T-6 (f5fb309): 5.4s
T-5 (cff8955): 5.5s
T-4 (be424b2): 5.8s
T-3 (f146798): 5.5s
T-2 (c7901aa): 5.5s
T-1 (bc7b0b8): 5.6s
T (current commit): 5.5s

largeDepsZisi: 10.4s

⬇️ 0.19% decrease vs. bc7b0b8

^  10.4s   10.6s   10.4s   10.4s   10.4s           10.4s   10.5s   10.6s   10.4s   10.5s   10.5s   10.4s  
│   ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐   10.3s    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (cacee3f): 17.2s
T-29 (52a6654): 21.3s
T-28 (c0b0b7a): 16.8s
T-27 (15399f4): 16.5s
T-26 (ac5532d): 16.7s
T-25 (e4d0ba9): 10.6s
T-24 (234379a): 10.6s
T-23 (5fc5321): 10.6s
T-22 (fee5d2e): 10.5s
T-21 (b8a39b6): 15.8s
T-20 (06ef08f): 10.5s
T-19 (c0a64fc): 10.5s
T-18 (bcb0388): 10.5s
T-17 (5ca965f): 10.5s
T-16 (46c96e2): 10.4s
T-15 (145bc5f): 10.6s
T-14 (8ac5b33): 10.5s
T-13 (fd6c7e6): 10.6s
T-12 (1c7ce98): 10.4s
T-11 (d40e8dd): 10.6s
T-10 (dc6d7a5): 10.4s
T-9 (31faa09): 10.4s
T-8 (0f23aa8): 10.4s
T-7 (e151134): 10.3s
T-6 (f5fb309): 10.4s
T-5 (cff8955): 10.5s
T-4 (be424b2): 10.6s
T-3 (f146798): 10.4s
T-2 (c7901aa): 10.5s
T-1 (bc7b0b8): 10.5s
T (current commit): 10.4s

Skn0tt

Please follow-up with a test that outlines what exactly was fixed here. Gonna approve for now.

…nd .dot directories (netlify/zip-it-and-ship-it#1678)

fix: fixes an issue where the included paths where missing symlinks a…

629da8e

…nd .dot directories

lukasholzer requested a review from a team as a code owner December 1, 2023 11:52

lukasholzer requested a review from Skn0tt December 1, 2023 11:52

Skn0tt approved these changes Dec 1, 2023

View reviewed changes

lukasholzer merged commit 81e451b into main Dec 1, 2023
10 checks passed

lukasholzer deleted the fix/fixes-an-issue-where-the-included-paths-did-not-where-copied-correctly branch December 1, 2023 12:13

token-generator-app bot mentioned this pull request Dec 1, 2023

chore(main): release 9.28.1 #1679

Merged

Skn0tt pushed a commit to netlify/build that referenced this pull request May 21, 2024

fix: fixes an issue where the included paths where missing symlinks a…

ba9b2df

…nd .dot directories (netlify/zip-it-and-ship-it#1678)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: fixes an issue where the included paths where missing symlinks and .dot directories #1678

fix: fixes an issue where the included paths where missing symlinks and .dot directories #1678

lukasholzer commented Dec 1, 2023

github-actions bot commented Dec 1, 2023

Skn0tt left a comment

fix: fixes an issue where the included paths where missing symlinks and .dot directories #1678

fix: fixes an issue where the included paths where missing symlinks and .dot directories #1678

Conversation

lukasholzer commented Dec 1, 2023

Summary

github-actions bot commented Dec 1, 2023

⏱ Benchmark results

largeDepsEsbuild: 1.4s

largeDepsNft: 5.5s

largeDepsZisi: 10.4s

Skn0tt left a comment

Choose a reason for hiding this comment