This repository has been archived by the owner on May 22, 2024. It is now read-only.
fix: add name and generator support to ISC
#1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱ Benchmark resultsComparing with 01f1c33 largeDepsEsbuild: 1.2s⬇️ 1.69% decrease vs. 01f1c33 Legend
largeDepsNft: 5.1s⬇️ 2.88% decrease vs. 01f1c33 Legend
largeDepsZisi: 9.2s⬇️ 5.76% decrease vs. 01f1c33 Legend
|
src/runtimes/node/index.ts
Outdated
| @@ -151,9 +151,9 @@ const zipFunction: ZipFunction = async function ({ | |||
| bundler: bundlerName, | |||
| bundlerWarnings, | |||
| config, | |||
| displayName: config?.name, | |||
| displayName: config?.name ?? staticAnalysisName, | |||
There was a problem hiding this comment.
Should the ISC value not take precedence?
There was a problem hiding this comment.
Both is fine. I gave precedence to the existing value, because that way it's not a breaking change for functions that have both defined right now. Happy to flip though.
There was a problem hiding this comment.
I think we should try to make this consistent with other configuration properties we have. I believe generally ISC takes precedence, but it's worth double-checking.
There was a problem hiding this comment.
yes, looks like we're giving ISC precedence for edge functions: https://github.com/netlify/edge-bundler/blob/0af1086fb92fa4eaa3e63709baac40df3f9ce06c/packages/edge-bundler/node/declaration.test.ts#L32
There was a problem hiding this comment.
flipped precedence in 14ac467
src/runtimes/node/index.ts
Outdated
| entryFilename: zipPath.entryFilename, | ||
| generator: config?.generator || getInternalValue(isInternal), | ||
| generator: staticAnalysisGenerator ?? config?.generator ?? getInternalValue(isInternal), |
There was a problem hiding this comment.
By changing || to ??, you're saying that an empty string might take precedence over a non-empty value. I don't think this should be the case.
Suggested change
| generator: staticAnalysisGenerator ?? config?.generator ?? getInternalValue(isInternal), | |
| generator: staticAnalysisGenerator || config?.generator || getInternalValue(isInternal), |
src/runtimes/node/index.ts
Outdated
| @@ -151,9 +151,9 @@ const zipFunction: ZipFunction = async function ({ | |||
| bundler: bundlerName, | |||
| bundlerWarnings, | |||
| config, | |||
| displayName: config?.name, | |||
| displayName: staticAnalysisName ?? config?.name, | |||
There was a problem hiding this comment.
Same as below.
Suggested change
| displayName: staticAnalysisName ?? config?.name, | |
| displayName: staticAnalysisName || config?.name, |
Skn0tt
added a commit
to netlify/build
that referenced
this pull request
May 21, 2024
…ip-it#1732) * feat: add support to ISC parser * feat: use parsed values * chore: remove unneeded import * chore: prettier * fix: flip precedence and extract to own test * fix: fmt * fix: switch back to logical or
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://linear.app/netlify/issue/COM-428/support-generator-and-name-in-isc-for-functions