Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

feat: allow JS functions with .mjs extension #619

Merged
merged 2 commits into from
Aug 24, 2021
Merged

Conversation

eduardoboucas
Copy link
Member

- Summary

Adds support for JavaScript functions using a .mjs extension. These functions will use the esbuild bundler.

Closes #588.

- Test plan

New test added.

- A picture of a cute animal (not mandatory but encouraged)

maxresdefault

@eduardoboucas eduardoboucas added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Aug 20, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 20, 2021

⏱ Benchmark results

Comparing with 452f7ee

largeDepsZisi: 1m 4s

⬇️ 10.68% decrease vs. 452f7ee

^                 1m 11.7s                                                                                
│                   ┌──┐          1m 6.5s 1m 9.5s                 1m 8.3s                 1m 7.9s         
│ 1m 3.6s           |  |            ┌──┐    ┌──┐  1m 3.8s           ┌──┐  1m 3.4s 1m 4.1s   ┌──┐   1m 4s  
│ ──┌──┐──1m 2.1s───┼──┼────────────┼──┼────┼──┼────┌──┐────────────┼──┼────┌──┐────┌──┐────┼──┼────┌──┐──
│   |  |    ┌──┐    |  |            |  |    |  |    |  |            |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |   54.7s    |  |    |  |    |  |            |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |   51.2s    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

@kodiakhq kodiakhq bot merged commit 73456ff into main Aug 24, 2021
@kodiakhq kodiakhq bot deleted the feat/mjs-functions branch August 24, 2021 09:01
Skn0tt pushed a commit to netlify/build that referenced this pull request May 21, 2024
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
automerge type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow .mjs entrypoints for functions
2 participants