NETOBSERV-1287: rtt blog updates to reflect last changes in ebpf agent #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msherif1234
force-pushed
the
rtt-update
branch
3 times, most recently
from
1c04b32
to
1e1f1bd
Compare
skrthomas
reviewed
Jan 15, 2024
skrthomas
reviewed
Jan 15, 2024
skrthomas
reviewed
Jan 15, 2024
skrthomas
reviewed
Jan 15, 2024
skrthomas
reviewed
Jan 15, 2024
blogs/rtt/index.md
Outdated
| an initial RTT of `10usec` is assigned. | ||
| This initial value for RTT may be considered quite low. | ||
|
|
||
| Upon triggering the eBPF (Extended Berkeley Packet Filter) socket, the flow's RTT |
There was a problem hiding this comment.
Suggested change
| Upon triggering the eBPF (Extended Berkeley Packet Filter) socket, the flow's RTT | |
| Upon triggering the eBPF (Extended Berkeley Packet Filter) socket, the RTT flow |
There was a problem hiding this comment.
instead of making flow possessive, I wonder if we can flip it to "RTT flow value"?
msherif1234
force-pushed
the
rtt-update
branch
from
1e1f1bd
to
799d887
Compare
msherif1234
changed the title
jpinsonneau
reviewed
Jan 18, 2024
msherif1234
force-pushed
the
rtt-update
branch
from
799d887
to
8827e99
Compare
Signed-off-by: Mohamed Mahmoud <mmahmoud@redhat.com>
msherif1234
force-pushed
the
rtt-update
branch
from
8827e99
to
5146e5b
Compare
jpinsonneau
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
additionl updates to RTT blog follow up for #54