-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements in confgen's dashboards generator #409
Comments
@jotak If we want more control over the grafana dashboards, then we probably should not be generating them completely automatically and uploading them directly. We should probably store the generated dashboards in a file, and then edit the file with the adjustments we want to make, and load the files into the operator. The drawback of this approach is that we need to have additional config files that are uploaded when bringing up the operator. We could perhaps embed them in the code, like we did with the metrics definitions files. |
@KalmanMeth embedding a manually generated json is what @OlivierCazade did in his PR, however I think maybe it could be interesting to support on confgen these features?
visualization:
type: grafana
grafana:
- rowTitle: "Top 5 node traffic"
- title: "Top 5 Flows rate egress per source and destination nodes"
expr:
- 'topk(5,rate(netobserv_node_egress_bytes_total[1m]))'
legendFormat: '{{pod}} : ({{SrcK8S_HostName}}) -> ({{DstK8S_HostName}})'
type: graphPanel
dashboard: netobserv
- title: "Top 5 Flows rate ingress per source and destination nodes"
expr:
- 'topk(5,rate(netobserv_node_ingress_bytes_total[1m]))'
legendFormat: '{{pod}} : ({{SrcK8S_HostName}}) -> ({{DstK8S_HostName}})'
type: graphPanel
dashboard: netobserv Note here, there can be several chart per row, and several expressions per chart, to comply with what Olivier did. |
@OlivierCazade did not use the FLP dashboards generator in netobserv/network-observability-operator#299 because he found some limitations. It would be nice to see if these limitations could be addressed. Quoting him:
cc @KalmanMeth @eranra , thoughts?
The text was updated successfully, but these errors were encountered: