NETOBSERV-123: Added infra health dashboard

[OlivierCazade]

This PR add infra health dashboard.

I first try to generate the dashboard using FLP confgen but I faced multiple limitations:

• Not possible to use rows definitions to have multiple foldable subsections
• Not possible to have multiple query on the same graph. Here I wanted to have ingested flows and sent to loki flows in the same graph
• Not possible to manage graph width so we can have mulitple graphs on the same row. Here for CPU and memory utilization.

You can check this branch which is working on how it was using FLP confgen.

If at some point we have to update this dashboard too often. We may want to implement this limitations in FLP confgen and use it.

[openshift-ci-robot]

@OlivierCazade: This pull request references NETOBSERV-123 which is a valid jira issue.

In response to this:

This PR add infra health dashboard.

I first try to generate the dashboard using FLP confgen but I faced multiple limitations:

• Not possible to use rows definitions to have multiple foldable subsections
• Not possible to have multiple query on the same graph. Here I wanted to have ingested flows and sent to loki flows in the same graph
• Not possible to manage graph width so we can have mulitple graphs on the same row. Here for CPU and memory utilization.
  You can check this branch which is working on how it was using FLP confgen.

If at some point we have to update this dashboard too often. We may want to implement this limitations in FLP confgen and use it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@OlivierCazade: This pull request references NETOBSERV-123 which is a valid jira issue.

In response to this:

This PR add infra health dashboard.

I first try to generate the dashboard using FLP confgen but I faced multiple limitations:

• Not possible to use rows definitions to have multiple foldable subsections
• Not possible to have multiple query on the same graph. Here I wanted to have ingested flows and sent to loki flows in the same graph
• Not possible to manage graph width so we can have mulitple graphs on the same row. Here for CPU and memory utilization.

You can check this branch which is working on how it was using FLP confgen.

If at some point we have to update this dashboard too often. We may want to implement this limitations in FLP confgen and use it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov]

Codecov Report

Merging #299 (648babe) into main (44e1b37) will increase coverage by 0.58%.
The diff coverage is 66.33%.

@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
+ Coverage   49.66%   50.24%   +0.58%     
==========================================
  Files          43       43              
  Lines        5020     5069      +49     
==========================================
+ Hits         2493     2547      +54     
+ Misses       2324     2316       -8     
- Partials      203      206       +3     

Flag	Coverage Δ
unittests	50.24% <66.33%> (+0.58%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
api/v1alpha1/flowcollector_types.go	100.00% <ø> (ø)
api/v1alpha1/flowcollector_webhook.go	0.00% <0.00%> (ø)
api/v1alpha1/zz_generated.conversion.go	0.27% <0.00%> (ø)
api/v1beta1/flowcollector_types.go	100.00% <ø> (ø)
api/v1beta1/zz_generated.deepcopy.go	42.33% <0.00%> (ø)
controllers/consoleplugin/consoleplugin_objects.go	92.45% <0.00%> (ø)
controllers/constants/constants.go	100.00% <ø> (ø)
controllers/flowcollector_controller.go	58.60% <40.00%> (-0.39%)	⬇️
pkg/helper/flowcollector.go	61.70% <50.00%> (ø)
controllers/flowlogspipeline/flp_reconciler.go	80.00% <78.57%> (+17.73%)	⬆️
... and 3 more

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[OlivierCazade]

Here is a screenshot of the deployed dashboard:

[OlivierCazade]

It looks like we have a regression because of some change in the monitoring operator.

The firing alert is not labelled with the namespace anymore and we were relying on this label to filter the alert for the banner.
I added an app label.

[stleerh]

No need to use string().
healthDashboardCMFile: healthDashboardEmbed,

[OlivierCazade]

Fixed, thanks!

[memodi]

@OlivierCazade - tests are failing ? could you PTAL ? let me know once they're fixed.

[jotak]

Should be capital O : NetObserv

[jotak]

FYI the failing test is something I experienced also (and fixed) in this PR: #294 - if it's merged first, this one should pass I think

[jotak]

@OlivierCazade it would be good to add tests - similar to the ones I added there: https://github.com/netobserv/network-observability-operator/pull/294/files#diff-363292a59bf24b26bb1b9f7996bb46014a7c4b7cb2bb483633eef84cf20ba934

[jotak]

/lgtm

[jotak]

/lgtm

[OlivierCazade]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: OlivierCazade

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [OlivierCazade]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment