NETOBSERV-918 dashboards follow-up #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jotak
commented
Mar 13, 2023
jotak
commented
- Delete (or do not create) dashboards CM when it is empty
- By default, do not create FLP metrics & dashboards
- Rename dashboard
- Add some tests
- Delete (or do not create) dashboards CM when it is empty - By default, do not create FLP metrics & dashboards - Rename dashboard - Add some tests
Codecov Report
@@ Coverage Diff @@
## main #294 +/- ##
==========================================
- Coverage 49.66% 49.33% -0.33%
==========================================
Files 43 43
Lines 5020 5035 +15
==========================================
- Hits 2493 2484 -9
- Misses 2324 2341 +17
- Partials 203 210 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
OlivierCazade
previously approved these changes
Mar 15, 2023
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.