NETOBSERV-678 Health dashboard link #305
Conversation
Codecov Report
@@ Coverage Diff @@
## main #305 +/- ##
=======================================
Coverage ? 58.78%
=======================================
Files ? 147
Lines ? 6461
Branches ? 769
=======================================
Hits ? 3798
Misses ? 2450
Partials ? 213
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
/lgtm |
|
/ok-to-test |
openshift-ci
bot
added
the
ok-to-test
|
New image: ["quay.io/netobserv/network-observability-console-plugin:d9f5302"]. It will expire after two weeks. |
| @@ -32,7 +36,8 @@ export const AlertBanner: React.FC<{ | |||
| actionClose={<AlertActionCloseButton onClose={onDelete} />} | |||
| actionLinks={ | |||
| <React.Fragment> | |||
| <AlertActionLink onClick={routeChange}>{t('View alert details')}</AlertActionLink> | |||
| <AlertActionLink onClick={routeAlert}>{t('View alert details')}</AlertActionLink> | |||
| <AlertActionLink onClick={routeDashboard}>{t('View health dashboard')}</AlertActionLink> | |||
There was a problem hiding this comment.
I guess you forgot to run make i18n, but also I'm surprised, isn't that part of the CI checks? I need to check
| @@ -32,7 +36,8 @@ export const AlertBanner: React.FC<{ | |||
| actionClose={<AlertActionCloseButton onClose={onDelete} />} | |||
| actionLinks={ | |||
| <React.Fragment> | |||
| <AlertActionLink onClick={routeChange}>{t('View alert details')}</AlertActionLink> | |||
| <AlertActionLink onClick={routeAlert}>{t('View alert details')}</AlertActionLink> | |||
| <AlertActionLink onClick={routeDashboard}>{t('View health dashboard')}</AlertActionLink> | |||
There was a problem hiding this comment.
Can you please regenerate i18n for that ?
| <Button | ||
| onClick={() => history.push('/monitoring/dashboards/grafana-dashboard-netobserv-health')} | ||
| variant="link" | ||
| > | ||
| {t('Show health dashboard')} | ||
| </Button> |
There was a problem hiding this comment.
Is there a way to check that the dashboard exists before showing the button ?
There was a problem hiding this comment.
Since it does not consume any resource by itself, as long as monitoring-operator is deployed, the dashboard is always deployed.
There was a problem hiding this comment.
Update: monitoring-operator is part of openshift core. So we should be fine here.
There was a problem hiding this comment.
as discussed, let's keep this as is
OlivierCazade
force-pushed
the
health-dashboard-link
branch
from
343c0ca
to
29971ec
Compare
github-actions
bot
removed
the
ok-to-test
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: OlivierCazade The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
Fix alert id calculation after monitoring operator update and add health dashboard link:
and here (bottom right):
Please note that this PR should be tested with the health dashboard PR