Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[breaking change] Fix protobuf decode for new time fields in ms #203

Merged
merged 1 commit into from
May 13, 2022
Merged

[breaking change] Fix protobuf decode for new time fields in ms #203

merged 1 commit into from
May 13, 2022

Conversation

jotak
Copy link
Member

@jotak jotak commented May 13, 2022

No description provided.

@jotak jotak requested a review from mariomac May 13, 2022 12:58
mariomac
mariomac approved these changes May 13, 2022
View reviewed changes
Copy link

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is a breaking change that I don't know whether we should document. I guess people using version 0.1.2 of the NOO will still deploy the older flowlogs-pipeline version.

@jotak
Copy link
Member Author

jotak commented May 13, 2022

Yes, true, actually this was breaking changes also in the console plugin and in the operator, as they all rely now on a new field that didn't exist before.
We must not forget to mention it in the next release note. Maybe we can use github labels to flag breaking changes...

@mariomac
Copy link

Another option is to keep both *Time and *TimeMs fields, documenting that the first ones are deprecated and eventually remove them in a future version.

@jotak jotak changed the title Fix protobuf decode for new time fields in ms [breaking change] Fix protobuf decode for new time fields in ms May 13, 2022
@jotak jotak merged commit 3f5317c into netobserv:main May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariomac mariomac mariomac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jotak @mariomac